Revert "Changed continuation_indent_size to 4" #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ed26117. As per discussion from the GitHub issue [1], the default continuation indent for Android should be 8 rather than 4. This matches the Android Kotlin style guide. [1] pinterest#120
|
@bradmcmanus 🙇♂️ |
|
hey @shyiko -- I notice that this commit is mysteriously not present on new releases of ktlint (I would expect it to be present on all releases after 0.14). did you accidentally force push this commit out? or maybe you removed it on purpose? thanks! |
|
Hi @bradmcmanus. |
|
@shyiko thank you for the clarification. I agree that the back and forth is troublesome. 4 is reasonable, especially if ktx is using 4. 4 it is! |
This was referenced Mar 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ed26117.
As per discussion from the GitHub issue [1], the default continuation
indent for Android should be 8 rather than 4. This matches the Android
Kotlin style guide.
[1] #120