Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass file path via user data properties. #1015

Merged

Conversation

Tapchicoma
Copy link
Collaborator

Previously, when ktlint failed to find '.editorconfig', file path was not passed to the rules. This lead for wrong "filename" rule behaviour.

Fixes #997

@Tapchicoma Tapchicoma force-pushed the 997/fix-filename-rule-may-not-work branch from a4cff1c to 9ebf6ec Compare December 16, 2020 20:44
Previously, when ktlint failed to find '.editorconfig', file path was not
passed to the rules. This lead for wrong "filename" rule behaviour.
@Tapchicoma Tapchicoma merged commit d7d226f into pinterest:master Dec 16, 2020
@Tapchicoma Tapchicoma deleted the 997/fix-filename-rule-may-not-work branch December 16, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FilenameRule does not find lint errors if missing editorconfig (new in 0.40.0)
1 participant