Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break dependency between string-template-indent and multiline-expression-wrapping #2504

Closed
paul-dingemans opened this issue Jan 16, 2024 · 0 comments · Fixed by #2505
Closed

Break dependency between string-template-indent and multiline-expression-wrapping #2504

paul-dingemans opened this issue Jan 16, 2024 · 0 comments · Fixed by #2505
Milestone
1.2

Comments

@paul-dingemans
Copy link
Collaborator

Currently the string-template-indent depends on the multiline-expression-wrapping to wrap the opening quotes of a multiline raw string literal in cases like below:

val foo = """
    some text
   """.trimIndent()

Although it is convenient from a technical perspective to rely on multiline-expression-wrapping to wrap the quotes, it forces the users to accept wrapping of all other multiline expressions as well.

As the wrapping logic for the opening quotes is not to complicated, it should be duplicated into the string-template-indent rule.

Originally posted by @paul-dingemans in #2338 (comment)
@paul-dingemans paul-dingemans added this to the 1.2 milestone Jan 16, 2024
paul-dingemans added a commit that referenced this issue Jan 16, 2024
@paul-dingemans
Break dependency between string-template-indent and multiline-express…
db3791c 
…ion-wrapping

If need be, the string-template-indent rule wraps the opening quotes of a multiline raw string literal to a new line. The `string-template-indent` can now be enabled regardless whether `multiline-expression-wrapping` is enabled.

Closes #2504
@paul-dingemans paul-dingemans mentioned this issue Jan 16, 2024
Merged
8 tasks
paul-dingemans added a commit that referenced this issue Jan 23, 2024
@paul-dingemans
Break dependency between string-template-indent and multiline-express…
30e8b1d 
…ion-wrapping (#2505)

* Break dependency between string-template-indent and multiline-expression-wrapping

If need be, the string-template-indent rule wraps the opening quotes of a multiline raw string literal to a new line. The `string-template-indent` can now be enabled regardless whether `multiline-expression-wrapping` is enabled.

Closes #2504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Break dependency between string-template-indent and multiline-expression-wrapping pinterest/ktlint
1 participant
@paul-dingemans