Unnecessary import error for used imports with * at the end

[illuzor]

Expected Behavior

No error

Observed Behavior

Error

Steps to Reproduce

Disable no-wildcard-imports rule and create a file with wildcard import

Your Environment

• Version of ktlint used: 0.43.0
• Name and version (or code for custom task) of integration used (Gradle plugin, Maven plugin, command line, custom Gradle task): gradlew:ktlintCheck
• Version of Gradle used (if applicable): 7.2
• Operating System and version: Windows 10
• Link to your project (if it's a public repository): ...

.editorconfig:

[*.{kt,kts}]
disabled_rules=no-wildcard-imports

Code:

import test.*

fun main() {
    Test1()
    Test2()
    Test3()
}

Output:

> Task :ktlintMainSourceSetCheck FAILED
D:\_sources\IDEA\tests\ktlint_error\src\main\kotlin\demo.kt:1:1 Unnecessary import
3 actionable tasks: 1 executed, 2 up-to-date

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ktlintMainSourceSetCheck'.
> A failure occurred while executing org.jlleitschuh.gradle.ktlint.worker.ConsoleReportWorkAction
   > KtLint found code style violations. Please see the following reports:
     - D:\_sources\IDEA\tests\ktlint_error\build\reports\ktlint\ktlintMainSourceSetCheck\ktlintMainSourceSetCheck.txt

Fails only if run by the plugin task gradlew ktlintCheck.
Does not fail if run ktlint from command line

Sample project: ktlint_error.zip

[romtsn]

you're disabling the wrong rule, it should actually be no-unused-imports

[illuzor]

@romtsn no, I`m disabling correct rule.
no-unused-imports should fail when wildcard import is unused, but in my case it is used and should not fail

[romtsn]

Ah, alright, then it's indeed a bug

[paul-dingemans]

@illuzor Please copy paste the code samples and output in the issue instead of an image. Also you should provide the expected code.

[paul-dingemans]

With file Foo.kt and content:

import some.path.*

interface Foo : Bar

and .editorconfig:

[*.{kt,kts}]
disabled_rules=no-wildcard-imports

ktlint does not fail for me as expected. However when I remove the disabled_rules from the .editorconfig it does fail.

[illuzor]

@paul-dingemans done

[paul-dingemans]

@romtsn This problem has been introduced by fixing #1256. I am stuck with trying to resolve this issue without reverting #1256.

The basic problem is that due to #1256 the import in code below is removed as no reference is found to package test.

import test.*

fun main() {
    Test() // defined in package test
}

So when visiting the CALL_EXPRESSION Test() or one level deeper at the IDENTIFIER node Test , I need to extract information from the psi node about the import that is required or the fully qualified name of the class. But in those nodes, I can not find any helpful information. Do you have any idea how to approach this?

[GabrielLasso]

@romtsn I had the same problem, then I created an example to reproduce it and I was going to report it, but I found this issue reporting the same problem.

Here is the example I created, I hope it is useful somehow

https://github.com/GabrielLasso/ktlint-bug-example

[henrik242]

@paul-dingemans Any progress on this? This bug removes in-use star imports when I use the formatter through kotlinter.

[paul-dingemans]

Sorry no progress. Waiting for response of @romtsn

[romtsn]

I'd need to look into that, but from the top of my head we probably can't extract this info easily. the proper way would be to depend on the compiler analysis, but that requires quite some setup

[henrik242]

My suggestion would be to revert the change that introduced this regression, and work from there. This way projects like kotlinter can continue to track the latest ktlint.

[Mehly]

Any updates on this issue yet?

We're unable to upgrade to the latest version of ktlint due to this issue because Android Studio by default enforces wildcard-imports after a certain threshold of imports from the same package has been reached.

[jakoss]

@Mehly You can turn that off in IntelliJ settings:

But I do agree, we're still on 0.41.0 since this is the last version that does work for us just fine

[romtsn]

@Mehly you can also disable it through .editorconfig ij_kotlin_name_count_to_use_star_import = 2147483647

[InTheCloudDan]

I just ran into this issue also, but it looks like if I disable that line with no-used-imports it keeps it there:
https://github.com/launchdarkly/ld-intellij/pull/13/files#diff-6f0b4a794e32dea16c8b2b28f38d8c2a6d7b1969a523045139b96ec474b753acR14

I'm not sure why wildcards are working in other files and it's just this one. But if I remove that disable line the import will be deleted.

[paul-dingemans]

@InTheCloudDan can you please try to minimize your example and just paste it here? Also, it would be better to use an EOL comment to prevent removal of the import on that specific line. Now you have disabled it for the remainder of the file.

[paul-dingemans]

@romtsn This problem has been introduced by fixing #1256. I am stuck with trying to resolve this issue without reverting #1256.

The basic problem is that due to #1256 the import in code below is removed as no reference is found to package test.

import test.*

fun main() {
    Test() // defined in package test
}

So when visiting the CALL_EXPRESSION Test() or one level deeper at the IDENTIFIER node Test , I need to extract information from the psi node about the import that is required or the fully qualified name of the class. But in those nodes, I can not find any helpful information. Do you have any idea how to approach this?

Solution of #1256 has been reverted as it leads to compilation failures when required wildcard important are removed. Downside is that some unused wilcard imports may not be detected. But that is not considered as harmfull.