Skip to content

Commit

Permalink
Remove incorrect TODO's
Browse files Browse the repository at this point in the history
  • Loading branch information
paul-dingemans committed Dec 11, 2022
1 parent 6b08f3b commit c3e1431
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ class SpacingAroundColonRuleTest {
fun foo(bar: String) {}
""".trimIndent()
spacingAroundColonRuleAssertThat(code)
// TODO: Offset col is not correct.
.hasLintViolation(1, 13, "Unexpected spacing before \":\"")
.isFormattedAs(formattedCode)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class SpacingAroundCommaRuleTest {
val foo2 = Foo(1, 3)
""".trimIndent()
spacingAroundCommaRuleAssertThat(code)
// TODO: Col offset is not correct
.hasLintViolation(1, 18, "Missing spacing after \",\"")
.isFormattedAs(formattedCode)
}
Expand Down Expand Up @@ -50,7 +49,6 @@ class SpacingAroundCommaRuleTest {
}
""".trimIndent()
spacingAroundCommaRuleAssertThat(code)
// TODO: Col offset is not correct
.hasLintViolation(2, 10, "Missing spacing after \",\"")
.isFormattedAs(formattedCode)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class SpacingAroundCurlyRuleTest {
""".trimIndent()
spacingAroundCurlyRuleAssertThat(code)
.hasLintViolations(
// TODO: Col offset is not correct
LintViolation(1, 17, "Missing spacing after \"{\""),
LintViolation(1, 23, "Missing spacing before \"}\""),
).isFormattedAs(formattedCode)
Expand Down Expand Up @@ -176,7 +175,6 @@ class SpacingAroundCurlyRuleTest {
fun <T> Array<T>.getFoo(): T = this[this.count { it == "foo" }]
""".trimIndent()
spacingAroundCurlyRuleAssertThat(code)
// TODO: Col offset is not correct
.hasLintViolation(1, 62, "Unexpected space after \"}\"")
.isFormattedAs(formattedCode)
}
Expand Down Expand Up @@ -213,12 +211,10 @@ class SpacingAroundCurlyRuleTest {
LintViolation(2, 15, "Missing spacing around \"{\""),
LintViolation(2, 26, "Missing spacing around \"}\""),
LintViolation(2, 47, "Missing spacing before \"{\""),
// TODO: Col offset is not correct
LintViolation(3, 13, "Missing spacing after \"{\""),
LintViolation(3, 31, "Missing spacing around \"{\""),
LintViolation(3, 40, "Missing spacing around \"}\""),
LintViolation(3, 61, "Missing spacing before \"{\""),
// TODO: Col offset is not correct
LintViolation(3, 63, "Missing spacing after \"}\""),
LintViolation(3, 63, "Missing spacing before \"}\""),
).isFormattedAs(formattedCode)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class SpacingAroundUnaryOperatorRuleTest {
spacingAroundUnaryOperatorRuleAssertThat(code)
.hasLintViolations(
LintViolation(2, 17, "Unexpected spacing in \"foo\" !!"),
// TODO: "foo3" should also be disallowed
// Space between the unary operator (!!) and the . is cleared by 'dot-spacing' rule
).isFormattedAs(formattedCode)
}

Expand Down

0 comments on commit c3e1431

Please sign in to comment.