Report an error when custom ruleset providers are still registered un…

…der the old package (#485)

* Also added explicit note into 0.32.0 CHANGELOG
* Fixed template service registration

Fixes #481

CHANGELOG.md

@@ -35,6 +35,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
 - Code now lives in `com.pinterest` package
 - groupId now `com.pinterest`
+- Custom ruleset `META-INF.services` file must be renamed to `com.pinterest.ktlint.core.RuleSetProvider`
 
 ## [0.31.0] - 2019-03-10
 

ktlint-core/src/main/kotlin/com/github/shyiko/ktlint/core/RuleSetProvider.kt

@@ -0,0 +1,9 @@
+package com.github.shyiko.ktlint.core
+
+/**
+ * https://github.com/pinterest/ktlint/issues/481
+ *
+ * Keep the RuleSetProvider in the old package so that we can detect it and throw an error.
+ */
+@Deprecated("RuleSetProvider has moved to com.pinterest.ktlint.core")
+interface RuleSetProvider

ktlint/src/main/kotlin/com/pinterest/ktlint/Main.kt

@@ -274,6 +274,15 @@ class KtlintCommandLine {
         if (!rulesets.isEmpty()) {
             loadJARs(dependencyResolver, rulesets)
         }
+
+        // Detect custom rulesets that have not been moved to the new package
+        if (ServiceLoader.load(com.github.shyiko.ktlint.core.RuleSetProvider::class.java).any()) {
+            System.err.println("[ERROR] Cannot load custom ruleset!")
+            System.err.println("[ERROR] RuleSetProvider has moved to com.pinterest.ktlint.core.")
+            System.err.println("[ERROR] Please rename META-INF/services/com.github.shyiko.ktlint.core.RuleSetProvider to META-INF/services/com.pinterest.ktlint.core.RuleSetProvider")
+            exitProcess(1)
+        }
+
         // standard should go first
         val ruleSetProviders =
             ServiceLoader.load(RuleSetProvider::class.java)