Ignore invalid function names when importing from "junit.framework" (#…

…2386) Closes #2383
pinterest · Nov 27, 2023 · a72dc96 · a72dc96
1 parent bfaa201
commit a72dc96
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/...tandard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/FunctionNamingRule.kt b/...tandard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/FunctionNamingRule.kt
@@ -188,6 +188,7 @@ public class FunctionNamingRule :
         private val TEST_LIBRARIES_SET =
             setOf(
                 "io.kotest",
+                "junit.framework",
                 "kotlin.test",
                 "org.junit",
                 "org.testng",

diff --git a/...ard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/FunctionNamingRuleTest.kt b/...ard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/FunctionNamingRuleTest.kt
@@ -257,4 +257,18 @@ class FunctionNamingRuleTest {
             """.trimIndent()
         functionNamingRuleAssertThat(code).hasNoLintViolations()
     }
+
+    @Test
+    fun `Issue 2383 - Given a class with tests in JUnit3 style`() {
+        val code =
+            """
+            import junit.framework.TestCase
+
+            class FooTest : TestCase() {
+                fun testFoo_bar() {
+                }
+            }
+            """.trimIndent()
+        functionNamingRuleAssertThat(code).hasNoLintViolations()
+    }
 }