Remove sdkman (#2693)

Almost every release, publishing to sdkman resulted in failures. Only a few users seems to depend on it. Closes #2692
pinterest · Jun 11, 2024 · 779a778 · 779a778
1 parent 54bf3c0
commit 779a778
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 30 deletions.
diff --git a/.github/workflows/publish-release-build.yml b/.github/workflows/publish-release-build.yml
@@ -47,11 +47,10 @@ jobs:
         if: ${{ success() }}
         run: echo "version=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
 
-      - name: Create zip for dependency managers
+      - name: Create zip for dependency manager(s)
         if: ${{ success() }}
         run: |
           cd ktlint-cli/build/run
-          # Doing this for Homebrew and https://github.com/sdkman/sdkman-cli/wiki/Well-formed-SDK-archives
           mkdir -p ktlint-${{ env.version }}/bin
           cp ktlint ktlint-${{ env.version }}/bin
           zip -rm ktlint-${{ env.version }}.zip ktlint-${{ env.version }}
@@ -79,14 +78,6 @@ jobs:
           formula-path: Formula/k/ktlint.rb
           download-url: https://github.com/pinterest/ktlint/releases/download/${{ env.version }}/ktlint-${{ env.version }}.zip
 
-#      - name: Release to sdkman
-#        if: ${{ success() }}
-#        env:
-#          SDKMAN_KEY: ${{ secrets.SDKMAN_KEY }}
-#          SDKMAN_TOKEN: ${{ secrets.SDKMAN_TOKEN }}
-#          SDKMAN_VERSION: ${{ env.version }}
-#        run: ./gradlew :ktlint-cli:sdkMajorRelease
-
       - name: Update Release documentation
         if: ${{ success() }}
         run: |

diff --git a/documentation/release-latest/docs/install/cli.md b/documentation/release-latest/docs/install/cli.md
@@ -48,11 +48,6 @@ Install with [MacPorts](https://www.macports.org/)
 port install ktlint
 ```
 
-Install with [SDKMAN! on macOS and Linux](https://sdkman.io/)
-```sh
-sdk install ktlint
-```
-
 On Arch Linux install package [ktlint <sup>AUR</sup>](https://aur.archlinux.org/packages/ktlint/).
 
 ## Command line usage

diff --git a/documentation/snapshot/docs/install/cli.md b/documentation/snapshot/docs/install/cli.md
@@ -48,11 +48,6 @@ Install with [MacPorts](https://www.macports.org/)
 port install ktlint
 ```
 
-Install with [SDKMAN! on macOS and Linux](https://sdkman.io/)
-```sh
-sdk install ktlint
-```
-
 On Arch Linux install package [ktlint <sup>AUR</sup>](https://aur.archlinux.org/packages/ktlint/).
 
 ## Command line usage

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -10,7 +10,6 @@ kotlinDev = "1.9.24"
 kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
 checksum = "org.gradle.crypto.checksum:1.4.0"
 shadow = "com.github.johnrengelman.shadow:8.1.1"
-sdkman = "io.sdkman.vendors:3.0.0"
 kotlinx-binary-compatibiltiy-validator = "org.jetbrains.kotlinx.binary-compatibility-validator:0.14.0"
 
 [libraries]

diff --git a/ktlint-cli/build.gradle.kts b/ktlint-cli/build.gradle.kts
@@ -4,7 +4,6 @@ plugins {
     id("ktlint-publication-library")
     alias(libs.plugins.shadow)
     alias(libs.plugins.checksum)
-    alias(libs.plugins.sdkman)
     signing
 }
 
@@ -164,11 +163,3 @@ tasks.withType<Test>().configureEach {
         systemProperty("ktlint-version", ktlintVersion)
     }
 }
-
-sdkman {
-    val sdkmanVersion = providers.environmentVariable("SDKMAN_VERSION").orElse(project.version.toString())
-    candidate = "ktlint"
-    version = sdkmanVersion
-    url = "https://github.com/pinterest/ktlint/releases/download/$sdkmanVersion/ktlint-$sdkmanVersion.zip"
-    hashtag = "ktlint"
-}