Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masonry: Add data-test-id for skeleton pins container #3811

Closed
wants to merge 1 commit into from

Conversation

rebeccayeyi
Copy link
Contributor

@rebeccayeyi rebeccayeyi commented Oct 18, 2024

Summary

What changed?

  • Adds data-test-id="masonry--skeleton-pins-container" to the loading state container

Why?

  • The skeleton loading state experiment led to unexpected PWT abort regressions. Since the skeleton pins are rendered as divs with styling and no images, this caused the Masonry profiler to abort because although Masonry technically loaded, there were no images present.
    • We will get around this by having the Masonry profiler look for this data test id and then opt out of adding these metrics to the PWT aborts.

Checklist

  • Added unit tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

@rebeccayeyi rebeccayeyi requested a review from a team as a code owner October 18, 2024 21:02
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d23e9fc
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/6712cccfb32a7600089ca9f4
😎 Deploy Preview https://deploy-preview-3811--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rebeccayeyi rebeccayeyi deleted the patch-1 branch October 18, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant