-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: Add ability to specify sticky columns #1395
Merged
ayeshakmaz
merged 19 commits into
pinterest:master
from
ayeshakmaz:ayesha/table-col-locking
Apr 7, 2021
+940
−19
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
dbdcc7f
Table: Add ability to freeze columns
ayeshakmaz e15c655
Working
ayeshakmaz 27808b1
RTL
ayeshakmaz 017cf54
WIP - white line
ayeshakmaz 5c4b15c
update
ayeshakmaz e2f5bc1
wip
ayeshakmaz 3f78e51
wip
ayeshakmaz 781ac10
wip
ayeshakmaz 6fcc898
sticky columns with shadow
ayeshakmaz b200636
Test fixes
ayeshakmaz 0a2e815
Tests
ayeshakmaz 602997c
PR feedback
ayeshakmaz d8a613c
Update types
ayeshakmaz 2c0ddde
type fixes
ayeshakmaz 4ea62ea
fix types
ayeshakmaz a4bd5a3
docs fix
ayeshakmaz dca34f3
state
ayeshakmaz 61baf75
fix
ayeshakmaz 8d9143c
docs bug
ayeshakmaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Tests
- Loading branch information
commit 0a2e815907e39c53ac1822fe0bd5d43bf4c60429
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Flow will be able to properly infer the type here, so you may want to add it. Looks like it's an optional enum?
?('left' | 'right')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, I think ryan was suggesting here
useState<('left' | 'right'| null)>(null)