Merge pull request #279 from jparise/merger

Merge 'thrift_tng' into master
pinterest · Sep 15, 2017 · 3d237d9 · 3d237d9
2 parents 4f4591f + 71b497d
commit 3d237d9
Show file tree

Hide file tree

Showing 118 changed files with 13,475 additions and 2,041 deletions.
diff --git a/.credo.exs b/.credo.exs
@@ -1,65 +1,130 @@
-%{configs: [
-  %{name: "default",
-    files: %{
-      included: ["lib/", "test/"],
-      excluded: ["_build/", "deps/", "ext/"]
-    },
-    requires: [],
-    check_for_updates: false,
+%{
+  configs: [
+    %{
+      #
+      # Run any config using `mix credo -C <name>`. If no config name is given
+      # "default" is used.
+      name: "default",
+      #
+      # These are the files included in the analysis:
+      files: %{
+        #
+        # You can give explicit globs or simply directories.
+        # In the latter case `**/*.{ex,exs}` will be used.
+        included: ["lib/", "src/"],
+        excluded: [~r"/_build/", ~r"/deps/"]
+      },
+      #
+      # If you create your own checks, you must specify the source files for
+      # them here, so they can be loaded by Credo before running the analysis.
+      requires: [],
+      #
+      # Credo automatically checks for updates, like e.g. Hex does.
+      # You can disable this behaviour below:
+      check_for_updates: false,
+      #
+      # If you want to enforce a style guide and need a more traditional linting
+      # experience, you can change `strict` to `true` below:
+      strict: false,
+      #
+      # If you want to use uncolored output by default, you can change `color`
+      # to `false` below:
+      color: true,
+      #
+      # You can customize the parameters of any check by adding a second element
+      # to the tuple.
+      #
+      # To disable a check put `false` as second element:
+      #
+      #     {Credo.Check.Design.DuplicatedCode, false}
+      #
+      checks: [
+        {Credo.Check.Consistency.ExceptionNames},
+        {Credo.Check.Consistency.LineEndings},
+        {Credo.Check.Consistency.MultiAliasImportRequireUse},
+        {Credo.Check.Consistency.ParameterPatternMatching},
+        {Credo.Check.Consistency.SpaceAroundOperators},
+        {Credo.Check.Consistency.SpaceInParentheses},
+        {Credo.Check.Consistency.TabsOrSpaces},
 
-    # You can customize the parameters of any check by adding a second element
-    # to the tuple.
-    #
-    # To disable a check put `false` as second element:
-    #
-    #     {Credo.Check.Design.DuplicatedCode, false}
-    #
-    checks: [
-      {Credo.Check.Consistency.ExceptionNames},
-      {Credo.Check.Consistency.LineEndings},
-      {Credo.Check.Consistency.SpaceAroundOperators},
-      {Credo.Check.Consistency.SpaceInParentheses},
-      {Credo.Check.Consistency.TabsOrSpaces},
+        # For some checks, like AliasUsage, you can only customize the priority
+        # Priority values are: `low, normal, high, higher`
+        {Credo.Check.Design.AliasUsage, priority: :low},
 
-      {Credo.Check.Design.AliasUsage, false},
-      {Credo.Check.Design.DuplicatedCode, excluded_macros: []},
+        # For others you can set parameters
 
-      {Credo.Check.Readability.FunctionNames},
-      {Credo.Check.Readability.LargeNumbers, false},
-      {Credo.Check.Readability.MaxLineLength, false},
-      {Credo.Check.Readability.ModuleAttributeNames},
-      {Credo.Check.Readability.ModuleNames},
-      {Credo.Check.Readability.ParenthesesInCondition},
-      {Credo.Check.Readability.PredicateFunctionNames},
-      {Credo.Check.Readability.Specs, false},
-      {Credo.Check.Readability.TrailingBlankLine},
-      {Credo.Check.Readability.TrailingWhiteSpace},
-      {Credo.Check.Readability.VariableNames},
-      {Credo.Check.Readability.RedundantBlankLines},
+        # If you don't want the `setup` and `test` macro calls in ExUnit tests
+        # or the `schema` macro in Ecto schemas to trigger DuplicatedCode, just
+        # set the `excluded_macros` parameter to `[:schema, :setup, :test]`.
+        {Credo.Check.Design.DuplicatedCode, excluded_macros: []},
 
-      {Credo.Check.Refactor.ABCSize, false},
-      {Credo.Check.Refactor.CondStatements},
-      {Credo.Check.Refactor.MatchInCondition},
-      {Credo.Check.Refactor.PipeChainStart, false},
-      {Credo.Check.Refactor.CyclomaticComplexity},
-      {Credo.Check.Refactor.NegatedConditionsInUnless},
-      {Credo.Check.Refactor.NegatedConditionsWithElse},
-      {Credo.Check.Refactor.Nesting},
-      {Credo.Check.Refactor.UnlessWithElse},
+        # You can also customize the exit_status of each check.
+        # If you don't want TODO comments to cause `mix credo` to fail, just
+        # set this value to 0 (zero).
+        {Credo.Check.Design.TagTODO, exit_status: 2},
+        {Credo.Check.Design.TagFIXME},
 
-      {Credo.Check.Warning.IExPry},
-      {Credo.Check.Warning.IoInspect, false},
-      {Credo.Check.Warning.NameRedeclarationByAssignment, false},
-      {Credo.Check.Warning.NameRedeclarationByCase, false},
-      {Credo.Check.Warning.NameRedeclarationByDef, false},
-      {Credo.Check.Warning.NameRedeclarationByFn, false},
-      {Credo.Check.Warning.BoolOperationOnSameValues},
-      {Credo.Check.Warning.UnusedEnumOperation},
-      {Credo.Check.Warning.UnusedKeywordOperation},
-      {Credo.Check.Warning.UnusedListOperation},
-      {Credo.Check.Warning.UnusedStringOperation},
-      {Credo.Check.Warning.UnusedTupleOperation},
-      {Credo.Check.Warning.OperationWithConstantResult},
-    ]
-  }
-]}
+        {Credo.Check.Readability.FunctionNames},
+        {Credo.Check.Readability.LargeNumbers},
+        {Credo.Check.Readability.MaxLineLength, priority: :low, max_length: 80},
+        {Credo.Check.Readability.ModuleAttributeNames},
+        {Credo.Check.Readability.ModuleDoc},
+        {Credo.Check.Readability.ModuleNames},
+        {Credo.Check.Readability.ParenthesesOnZeroArityDefs, false},
+        {Credo.Check.Readability.ParenthesesInCondition},
+        {Credo.Check.Readability.PredicateFunctionNames},
+        {Credo.Check.Readability.PreferImplicitTry},
+        {Credo.Check.Readability.RedundantBlankLines},
+        {Credo.Check.Readability.StringSigils},
+        {Credo.Check.Readability.TrailingBlankLine},
+        {Credo.Check.Readability.TrailingWhiteSpace},
+        {Credo.Check.Readability.VariableNames},
+        {Credo.Check.Readability.Semicolons},
+        {Credo.Check.Readability.SpaceAfterCommas},
+
+        {Credo.Check.Refactor.DoubleBooleanNegation},
+        {Credo.Check.Refactor.CondStatements},
+        {Credo.Check.Refactor.CyclomaticComplexity},
+        {Credo.Check.Refactor.FunctionArity},
+        {Credo.Check.Refactor.MatchInCondition},
+        {Credo.Check.Refactor.NegatedConditionsInUnless},
+        {Credo.Check.Refactor.NegatedConditionsWithElse},
+        {Credo.Check.Refactor.Nesting},
+        {Credo.Check.Refactor.PipeChainStart},
+        {Credo.Check.Refactor.UnlessWithElse},
+
+        {Credo.Check.Warning.BoolOperationOnSameValues},
+        {Credo.Check.Warning.IExPry},
+        {Credo.Check.Warning.IoInspect},
+        {Credo.Check.Warning.LazyLogging},
+        {Credo.Check.Warning.OperationOnSameValues},
+        {Credo.Check.Warning.OperationWithConstantResult},
+        {Credo.Check.Warning.UnusedEnumOperation},
+        {Credo.Check.Warning.UnusedFileOperation},
+        {Credo.Check.Warning.UnusedKeywordOperation},
+        {Credo.Check.Warning.UnusedListOperation},
+        {Credo.Check.Warning.UnusedPathOperation},
+        {Credo.Check.Warning.UnusedRegexOperation},
+        {Credo.Check.Warning.UnusedStringOperation},
+        {Credo.Check.Warning.UnusedTupleOperation},
+
+        # Controversial and experimental checks (opt-in, just remove `, false`)
+        #
+        {Credo.Check.Refactor.ABCSize, false},
+        {Credo.Check.Refactor.AppendSingleItem, false},
+        {Credo.Check.Refactor.VariableRebinding, false},
+        {Credo.Check.Warning.MapGetUnsafePass, false},
+
+        # Deprecated checks (these will be deleted after a grace period)
+        {Credo.Check.Readability.Specs, false},
+        {Credo.Check.Warning.NameRedeclarationByAssignment, false},
+        {Credo.Check.Warning.NameRedeclarationByCase, false},
+        {Credo.Check.Warning.NameRedeclarationByDef, false},
+        {Credo.Check.Warning.NameRedeclarationByFn, false},
+
+        # Custom checks can be created using `mix credo.gen.check`.
+        #
+      ]
+    }
+  ]
+}
diff --git a/.dialyzerignore b/.dialyzerignore
@@ -0,0 +1 @@
+Function yyrev/2 will never be called
diff --git a/.ebert.yml b/.ebert.yml
@@ -7,4 +7,3 @@ engines:
 exclude_paths:
 - ci
 - doc
-- ext
diff --git a/.gitignore b/.gitignore
@@ -1,9 +1,14 @@
 /_build
+/bench/snapshots
+/cover
 /deps
 /doc
+/lib/generated
 /src/thrift_lexer.erl
 /src/thrift_parser.erl
-/test/fixtures/app/src
+/test/fixtures/app/_build
+/test/fixtures/app/lib
+/tmp
 erl_crash.dump
 *.ez
 log.*

diff --git a/.gitmodules b/.gitmodules
diff --git a/.travis.yml b/.travis.yml
@@ -1,17 +1,17 @@
 language: elixir
 elixir: 1.3.4
-otp_release: 19.2
+otp_release: 18.2
 matrix:
   include:
-    - elixir: 1.2.6
-      otp_release: 18.2
+    - elixir: 1.5.0
+      otp_release: 20.0
 sudo: required
 dist: trusty
 services: docker
 env:
   - THRIFT=${TRAVIS_BUILD_DIR}/ci/thrift-docker
 after_script:
-  - mix coveralls.travis
+  - MIX_ENV=test mix coveralls.travis
 cache:
   directories:
   - $HOME/.mix/archives