Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9932] Remove thrift dependency of Tools module #9996

Merged
merged 1 commit into from
May 25, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented May 25, 2023

No description provided.

@emeroad emeroad added this to the 2.6.0 milestone May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #9996 (fc60341) into master (1e5504f) will decrease coverage by 0.08%.
The diff coverage is 10.66%.

@@             Coverage Diff              @@
##             master    #9996      +/-   ##
============================================
- Coverage     39.03%   38.96%   -0.08%     
  Complexity    11799    11799              
============================================
  Files          3595     3604       +9     
  Lines         93864    94038     +174     
  Branches      10380    10389       +9     
============================================
- Hits          36644    36641       -3     
- Misses        54068    54244     +176     
- Partials       3152     3153       +1     
Impacted Files Coverage Δ
...orp/pinpoint/tools/NetworkAvailabilityChecker.java 0.00% <0.00%> (ø)
...pinpoint/tools/network/AbstractNetworkChecker.java 0.00% <0.00%> (ø)
...m/navercorp/pinpoint/tools/network/TCPChecker.java 0.00% <0.00%> (ø)
...npoint/tools/network/grpc/GrpcTransportConfig.java 0.00% <0.00%> (ø)
...va/com/navercorp/pinpoint/tools/utils/IOUtils.java 0.00% <0.00%> (ø)
...ava/com/navercorp/pinpoint/tools/utils/Logger.java 0.00% <0.00%> (ø)
...om/navercorp/pinpoint/tools/utils/NumberUtils.java 0.00% <0.00%> (ø)
...vercorp/pinpoint/tools/utils/PropertyResolver.java 88.88% <88.88%> (ø)

... and 7 files with indirect coverage changes

@emeroad emeroad linked an issue May 25, 2023 that may be closed by this pull request
@emeroad emeroad merged commit c90ba0d into pinpoint-apm:master May 25, 2023
@emeroad emeroad deleted the #9932_tools branch May 26, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thrift transport End of Life Support
1 participant