Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9932] Remove thrift dependency of Collector module #10000

Merged
merged 1 commit into from
May 30, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented May 26, 2023

No description provided.

@emeroad emeroad added this to the 2.6.0 milestone May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #10000 (eda4657) into master (888bb62) will decrease coverage by 0.34%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##             master   #10000      +/-   ##
============================================
- Coverage     38.98%   38.64%   -0.34%     
+ Complexity    11807    11601     -206     
============================================
  Files          3604     3572      -32     
  Lines         94038    93064     -974     
  Branches      10389    10269     -120     
============================================
- Hits          36659    35965     -694     
+ Misses        54224    54019     -205     
+ Partials       3155     3080      -75     
Impacted Files Coverage Δ
...rp/pinpoint/collector/PinpointCollectorModule.java 0.00% <ø> (ø)
...t/collector/cluster/route/DefaultRouteHandler.java 38.46% <0.00%> (+2.74%) ⬆️
...nt/collector/cluster/route/StreamRouteHandler.java 0.00% <0.00%> (ø)
.../collector/service/ClusterAgentCommandService.java 0.00% <ø> (ø)
...oint/collector/cluster/ClusterPointRepository.java 27.65% <50.00%> (-31.17%) ⬇️
.../pinpoint/flink/config/DataReceiverProperties.java 88.46% <100.00%> (ø)

... and 21 files with indirect coverage changes

@emeroad emeroad merged commit bbc0ee2 into pinpoint-apm:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant