Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark multiple sql execution within single transaction as error #10604

Closed
kojandy opened this issue Jan 11, 2024 · 0 comments · Fixed by #10596 or #10621
Closed

Mark multiple sql execution within single transaction as error #10604

kojandy opened this issue Jan 11, 2024 · 0 comments · Fixed by #10596 or #10621
Assignees
@kojandy
Milestone
3.0.0

Comments

@kojandy
Copy link
Contributor

kojandy commented Jan 11, 2024

For ease of detection of n+1 queries, mark a transaction as an error when there are too many SQL executions within a single transaction.
@kojandy kojandy self-assigned this Jan 11, 2024
@kojandy kojandy mentioned this issue Jan 11, 2024
Merged
kojandy added a commit to kojandy/pinpoint that referenced this issue Jan 11, 2024
@kojandy
[pinpoint-apm#10604] Mark multiple sql executions as error
789d000
kojandy added a commit to kojandy/pinpoint that referenced this issue Jan 15, 2024
@kojandy
[pinpoint-apm#10604] Mark multiple sql executions as error
2faef10
kojandy added a commit to kojandy/pinpoint that referenced this issue Jan 15, 2024
@kojandy
[pinpoint-apm#10604] Mark multiple sql executions as error
0f54805
emeroad pushed a commit that referenced this issue Jan 15, 2024
@kojandy @emeroad
[#10604] Mark multiple sql executions as error
447e328
emeroad added a commit to emeroad/pinpoint that referenced this issue Jan 17, 2024
@emeroad
[pinpoint-apm#10604] Move ExecuteQuery state to SpanEvent
5597513
@emeroad emeroad added this to the 3.0.0 milestone Jan 17, 2024
emeroad added a commit that referenced this issue Jan 17, 2024
@emeroad
[#10604] Move ExecuteQuery state to SpanEvent
4daf903
@emeroad emeroad linked a pull request Jan 17, 2024 that will close this issue
[#10604] Move ExecuteQuery state to SpanEvent #10621
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kojandy kojandy

Labels
None yet
Projects
None yet
Milestone
3.0.0
2 participants
@kojandy @emeroad