Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is cxx extension #655

Merged
merged 1 commit into from
Aug 1, 2024
Merged

This is cxx extension #655

merged 1 commit into from
Aug 1, 2024

Conversation

remicollet
Copy link
Contributor

Fix PHP_NEW_EXTENSION to use C++ linker, so there is no need to add libstdc++ which is present by default with cxx command.

@eeliu eeliu self-requested a review July 29, 2024 08:41
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (5187cc0) to head (0adff49).
Report is 12 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #655      +/-   ##
==========================================
- Coverage   80.79%   80.63%   -0.16%     
==========================================
  Files          22       22              
  Lines        1536     1539       +3     
  Branches      165      166       +1     
==========================================
  Hits         1241     1241              
- Misses        162      164       +2     
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu
Copy link
Collaborator

eeliu commented Aug 1, 2024

@remicollet Can you resolve this conflicts ?

@remicollet
Copy link
Contributor Author

Rebased

@remicollet
Copy link
Contributor Author

Notice: without this change, the build will be broken on RHEL and clones when using alternative GCC versions (gcc-toolset) which may need additional static libraries only added when invoked as cxx (so libstdc++ is not enough)

Copy link
Collaborator

@eeliu eeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eeliu eeliu merged commit 644ddaa into pinpoint-apm:dev Aug 1, 2024
71 of 72 checks passed
@remicollet remicollet deleted the issue-cxx branch August 1, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants