Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs/_pymongo plugin does not working in asynchronous framework #557

Closed
eeliu opened this issue Nov 22, 2023 · 2 comments · Fixed by #558
Closed

libs/_pymongo plugin does not working in asynchronous framework #557

eeliu opened this issue Nov 22, 2023 · 2 comments · Fixed by #558
Assignees
@eeliu
Labels
bug Something isn't working
Milestone
v0.4.12

Comments

@eeliu
Copy link
Collaborator

eeliu commented Nov 22, 2023

Describe the bug

insert_one interceptor never called in fastapi

To Reproduce
Steps to reproduce the behavior:

  1. enable use_starlette_context()
  2. loading monkey_patch_for_pinpoint

mongo insert_one was missing in web
@eeliu eeliu added the bug Something isn't working label Nov 22, 2023
@eeliu
Copy link
Collaborator Author

eeliu commented Nov 22, 2023

Solution

use monitoring.register add a hook when operation.

eeliu added a commit to eeliu/pinpoint-c-agent that referenced this issue Nov 22, 2023
@eeliu
fix(libs): bug in _pymongo
61d4512 
- clear logging format
- fix pinpoint-apm#557

fix 557
eeliu added a commit to eeliu/pinpoint-c-agent that referenced this issue Nov 22, 2023
@eeliu
fix(libs): bug in _pymongo
fdcf572 
- clear logging format
- fix pinpoint-apm#557

fix 557
@eeliu eeliu mentioned this issue Nov 22, 2023
Merged
@eeliu eeliu self-assigned this Nov 22, 2023
eeliu added a commit that referenced this issue Nov 22, 2023
@eeliu
fix(libs): bug in _pymongo (#558)
c18bede 
- clear logging format
- fix #557
@eeliu
Copy link
Collaborator Author

eeliu commented Nov 22, 2023

curl -X 'GET'
'http://localhost:8186/add_span/?id=123&start_time=23414123'
-H 'accept: application/json'

You can get such call stack

image

@EyelynSu

eeliu added a commit to eeliu/pinpoint-c-agent that referenced this issue Nov 22, 2023
@eeliu
fix motor missing pinpoint-apm#557
0a2f778
eeliu added a commit that referenced this issue Nov 22, 2023
@eeliu
fix motor missing #557 (#559)
511a0a8 
add motor requirement
@eeliu eeliu added this to the v0.4.12 milestone Dec 4, 2023
eeliu added a commit that referenced this issue Mar 28, 2024
@eeliu
fix(libs): bug in _pymongo (#558)
1fae0a9 
- clear logging format
- fix #557
eeliu added a commit that referenced this issue Mar 28, 2024
@eeliu
fix motor missing #557 (#559)
0513b8c 
add motor requirement
eeliu added a commit that referenced this issue Mar 28, 2024
@eeliu
fix(libs): bug in _pymongo (#558)
1fbd1db 
- clear logging format
- fix #557
eeliu added a commit that referenced this issue Mar 28, 2024
@eeliu
fix motor missing #557 (#559)
f75eed4 
add motor requirement
eeliu added a commit that referenced this issue Mar 28, 2024
@eeliu
fix(libs): bug in _pymongo (#558)
cf136d3 
- clear logging format
- fix #557
eeliu added a commit that referenced this issue Mar 28, 2024
@eeliu
fix motor missing #557 (#559)
030adcb 
add motor requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eeliu eeliu

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging a pull request may close this issue.

fix(libs): bug in _pymongo eeliu/pinpoint-c-agent
1 participant
@eeliu