Clear cached parsed chindings when they're changed with .setBindings #893
Conversation
| var pino = require(require.resolve('./../../../')) | ||
| var log = pino({ prettyPrint: true }).child({ foo: 123 }) | ||
| log.info('before') | ||
| log.setBindings({ foo: 456, bar: 789 }) |
There was a problem hiding this comment.
Are we really exposing this as a public API? Can we exercise the code path without using this function?
There was a problem hiding this comment.
Which function are you referring to, .setBindings()? The point of this PR is to make that method work correctly when a prettifier is in use.
There was a problem hiding this comment.
setBindings is already exposed.
There was a problem hiding this comment.
I don't see it in our docs -- https://getpino.io/#/docs/api
There was a problem hiding this comment.
Maybe it should be documented, anyway this PR does not add it.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This fixes #890; see that issue for discussion.