-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use boolean flag to ensure serializers are applied once #1976
use boolean flag to ensure serializers are applied once #1976
Conversation
I am not following. Can you please provide a direct statement of the problem this is solving? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sure I had created this PR #1971 to fix serializers being applied twice to logs, i.e, before The fix only applies serializers if transmit is not defined, which breaks the original implementation, where we want apply serializers for |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.21.0` -> `9.3.1`](https://renovatebot.com/diffs/npm/pino/8.21.0/9.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.21.0/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.21.0/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.3.1`](https://togithub.com/pinojs/pino/releases/tag/v9.3.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.3.0...v9.3.1) **Full Changelog**: pinojs/pino@v9.3.0...v9.3.1 ### [`v9.3.0`](https://togithub.com/pinojs/pino/compare/v9.2.0...92f2cee98e83d3f864b228a6e1dc29a31e54ba49) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.2.0...v9.3.0) ### [`v9.2.0`](https://togithub.com/pinojs/pino/releases/tag/v9.2.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.1.0...v9.2.0) #### What's Changed - shallow clone target options by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1973](https://togithub.com/pinojs/pino/pull/1973) - add logger instance as third parameter by [@​emmyakin](https://togithub.com/emmyakin) in [https://github.com/pinojs/pino/pull/1977](https://togithub.com/pinojs/pino/pull/1977) - use boolean flag to ensure serializers are applied once by [@​emmyakin](https://togithub.com/emmyakin) in [https://github.com/pinojs/pino/pull/1976](https://togithub.com/pinojs/pino/pull/1976) - suppport messageKey in pino/browser by [@​emmyakin](https://togithub.com/emmyakin) in [https://github.com/pinojs/pino/pull/1980](https://togithub.com/pinojs/pino/pull/1980) - Fixing browser side child log issue ([#​960](https://togithub.com/pinojs/pino/issues/960)) child level can now be set at cr… by [@​stevel032](https://togithub.com/stevel032) in [https://github.com/pinojs/pino/pull/1986](https://togithub.com/pinojs/pino/pull/1986) #### New Contributors - [@​stevel032](https://togithub.com/stevel032) made their first contribution in [https://github.com/pinojs/pino/pull/1986](https://togithub.com/pinojs/pino/pull/1986) **Full Changelog**: pinojs/pino@v9.1.0...v9.2.0 ### [`v9.1.0`](https://togithub.com/pinojs/pino/releases/tag/v9.1.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.0.0...v9.1.0) #### What's Changed - fix(transport-stream): Fix import error when using pkg with node v20 by [@​nagyszabi](https://togithub.com/nagyszabi) in [https://github.com/pinojs/pino/pull/1949](https://togithub.com/pinojs/pino/pull/1949) - Update LTS doc by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/pinojs/pino/pull/1955](https://togithub.com/pinojs/pino/pull/1955) - Update pino types for browser.formatters by [@​KatelynKim](https://togithub.com/KatelynKim) in [https://github.com/pinojs/pino/pull/1946](https://togithub.com/pinojs/pino/pull/1946) - add node v22 to CI by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1953](https://togithub.com/pinojs/pino/pull/1953) - Add Platformatic to sponsors by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1956](https://togithub.com/pinojs/pino/pull/1956) - Update h3 example by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1968](https://togithub.com/pinojs/pino/pull/1968) - Support file URLs when configuring multiple transports by [@​haines](https://togithub.com/haines) in [https://github.com/pinojs/pino/pull/1961](https://togithub.com/pinojs/pino/pull/1961) - Adding support for mix\&match pipelines by [@​dbacarel](https://togithub.com/dbacarel) in [https://github.com/pinojs/pino/pull/1954](https://togithub.com/pinojs/pino/pull/1954) - apply serializers to args once before asObject or transmit by [@​emmyakin](https://togithub.com/emmyakin) in [https://github.com/pinojs/pino/pull/1971](https://togithub.com/pinojs/pino/pull/1971) - build(deps-dev): bump pino-pretty from 10.3.1 to 11.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1933](https://togithub.com/pinojs/pino/pull/1933) - build(deps): bump sonic-boom from 3.8.1 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1960](https://togithub.com/pinojs/pino/pull/1960) - build(deps): bump pino-std-serializers from 6.2.2 to 7.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1957](https://togithub.com/pinojs/pino/pull/1957) - build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1937](https://togithub.com/pinojs/pino/pull/1937) - build(deps): bump actions/dependency-review-action from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1894](https://togithub.com/pinojs/pino/pull/1894) - build(deps): bump pnpm/action-setup from 2.4.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1913](https://togithub.com/pinojs/pino/pull/1913) - Drop yarn support and update pnpm by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1972](https://togithub.com/pinojs/pino/pull/1972) - build(deps): bump thread-stream from 2.7.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1959](https://togithub.com/pinojs/pino/pull/1959) #### New Contributors - [@​nagyszabi](https://togithub.com/nagyszabi) made their first contribution in [https://github.com/pinojs/pino/pull/1949](https://togithub.com/pinojs/pino/pull/1949) - [@​haines](https://togithub.com/haines) made their first contribution in [https://github.com/pinojs/pino/pull/1961](https://togithub.com/pinojs/pino/pull/1961) - [@​emmyakin](https://togithub.com/emmyakin) made their first contribution in [https://github.com/pinojs/pino/pull/1971](https://togithub.com/pinojs/pino/pull/1971) **Full Changelog**: pinojs/pino@v9.0.0...v9.1.0 ### [`v9.0.0`](https://togithub.com/pinojs/pino/compare/v8.21.0...4f8ea32aa69ec94b2fb5561716a7701aec991ce7) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.21.0...v9.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
When
opt.browser.transmit
is defined, serializers are not applied towrite
Conditions when serializers should be applied
opts.serialize
istrue
ordefined
write
andtransmit
operationsopts.serialize
isfalse
orundefined
transmit
operation only