Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify setBindings() comment #1419

Merged
merged 1 commit into from
Apr 27, 2022
Merged

docs: clarify setBindings() comment #1419

merged 1 commit into from
Apr 27, 2022

Conversation

deanhaleem
Copy link
Contributor

setBindings() does not actually overwrite bindings, so clarifying that it simply adds to the existing bindings. Addresses #1418

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ab95023 into pinojs:master Apr 27, 2022
@deanhaleem deanhaleem deleted the docs-set-bindings branch April 27, 2022 23:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants