Fix: add missing useOnlyCustomProps options to type definitions #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
May 27, 2024
|
@mcollina absolutely! I'm not familiar with tsd, but based on the work on the test suite it seemed adding the property suffice for the test expectation. please let me know if it requires more work 🙇🏼 disclaimer: I opted to amend the existing commit to not clutter the git history - this way the change and the test are located in a single commit. I hope you don't mind! |
renovate bot
referenced
this pull request
in fwouts/previewjs
Jun 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`^11.1.0` -> `^11.2.1`](https://renovatebot.com/diffs/npm/pino-pretty/11.1.0/11.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-pretty (pino-pretty)</summary> ### [`v11.2.1`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.1): v11 [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.0...v11.2.1) #### What's Changed - Fix: add missing useOnlyCustomProps options to type definitions by [@​pcdevil](https://togithub.com/pcdevil) in [https://github.com/pinojs/pino-pretty/pull/514](https://togithub.com/pinojs/pino-pretty/pull/514) #### New Contributors - [@​pcdevil](https://togithub.com/pcdevil) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/514](https://togithub.com/pinojs/pino-pretty/pull/514) **Full Changelog**: pinojs/pino-pretty@v11.2.0...v11.2.1 ### [`v11.2.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.0) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.1.0...v11.2.0) #### What's Changed - fix: add injection of lacking arguments of customPrettifiers by [@​pasha-vuiko](https://togithub.com/pasha-vuiko) in [https://github.com/pinojs/pino-pretty/pull/501](https://togithub.com/pinojs/pino-pretty/pull/501) #### New Contributors - [@​pasha-vuiko](https://togithub.com/pasha-vuiko) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/501](https://togithub.com/pinojs/pino-pretty/pull/501) **Full Changelog**: pinojs/pino-pretty@v11.1.0...v11.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in open-feature/playground
Jul 28, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`11.0.0` -> `11.2.2`](https://renovatebot.com/diffs/npm/pino-pretty/11.0.0/11.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-pretty (pino-pretty)</summary> ### [`v11.2.2`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.2) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.1...v11.2.2) #### What's Changed - Type fixes by [@​joshkel](https://togithub.com/joshkel) in [https://github.com/pinojs/pino-pretty/pull/522](https://togithub.com/pinojs/pino-pretty/pull/522) #### New Contributors - [@​joshkel](https://togithub.com/joshkel) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/522](https://togithub.com/pinojs/pino-pretty/pull/522) **Full Changelog**: pinojs/pino-pretty@v11.2.1...v11.2.2 ### [`v11.2.1`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.1): v11 [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.0...v11.2.1) #### What's Changed - Fix: add missing useOnlyCustomProps options to type definitions by [@​pcdevil](https://togithub.com/pcdevil) in [https://github.com/pinojs/pino-pretty/pull/514](https://togithub.com/pinojs/pino-pretty/pull/514) #### New Contributors - [@​pcdevil](https://togithub.com/pcdevil) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/514](https://togithub.com/pinojs/pino-pretty/pull/514) **Full Changelog**: pinojs/pino-pretty@v11.2.0...v11.2.1 ### [`v11.2.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.0) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.1.0...v11.2.0) #### What's Changed - fix: add injection of lacking arguments of customPrettifiers by [@​pasha-vuiko](https://togithub.com/pasha-vuiko) in [https://github.com/pinojs/pino-pretty/pull/501](https://togithub.com/pinojs/pino-pretty/pull/501) #### New Contributors - [@​pasha-vuiko](https://togithub.com/pasha-vuiko) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/501](https://togithub.com/pinojs/pino-pretty/pull/501) **Full Changelog**: pinojs/pino-pretty@v11.1.0...v11.2.0 ### [`v11.1.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.1.0) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v11.0.0...v11.1.0) #### What's Changed - Bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-pretty/pull/503](https://togithub.com/pinojs/pino-pretty/pull/503) - Fix Object.create(null) by [@​chrisands](https://togithub.com/chrisands) in [https://github.com/pinojs/pino-pretty/pull/507](https://togithub.com/pinojs/pino-pretty/pull/507) - Bump sonic-boom from 3.8.1 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-pretty/pull/509](https://togithub.com/pinojs/pino-pretty/pull/509) - Bump pino from 8.21.0 to 9.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-pretty/pull/510](https://togithub.com/pinojs/pino-pretty/pull/510) - feat: automatically consume pino config when using pino@>=8.21.0 by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino-pretty/pull/508](https://togithub.com/pinojs/pino-pretty/pull/508) - fix: pass error-like objects ([#​505](https://togithub.com/pinojs/pino-pretty/issues/505)) by [@​aqemi](https://togithub.com/aqemi) in [https://github.com/pinojs/pino-pretty/pull/506](https://togithub.com/pinojs/pino-pretty/pull/506) - Add node v22 to CI by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino-pretty/pull/511](https://togithub.com/pinojs/pino-pretty/pull/511) - feat: Added exports color support in TTY by [@​synapse](https://togithub.com/synapse) in [https://github.com/pinojs/pino-pretty/pull/513](https://togithub.com/pinojs/pino-pretty/pull/513) #### New Contributors - [@​chrisands](https://togithub.com/chrisands) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/507](https://togithub.com/pinojs/pino-pretty/pull/507) - [@​aqemi](https://togithub.com/aqemi) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/506](https://togithub.com/pinojs/pino-pretty/pull/506) - [@​synapse](https://togithub.com/synapse) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/513](https://togithub.com/pinojs/pino-pretty/pull/513) **Full Changelog**: pinojs/pino-pretty@v11.0.0...v11.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/playground). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I started using pino-pretty in a TypeScript project and noticed the
useOnlyCustomPropsoption is not present in the type definitions module. The JSDoc lists it at L71-72, so I assume it was a copy-paste error at some time.This pull request addresses this discrepancy by copying the readme's description!