Give customProps access to the response #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Jan 14, 2022
logger.js
Outdated
| if (customPropBindings) { | ||
| fullReqLogger = fullReqLogger.child(customPropBindings) | ||
| } | ||
| fullReqLogger = fullReqLogger.child(customPropBindings) |
There was a problem hiding this comment.
Could you please restore these changes? This if gives us significant throughput. See #196 for more details.
|
@mcollina @travisbeck -- I don't understand why customProps child needs to be added in both the Since we are setting the child logger in the middleware - it should be the same instance in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues with #168 and also fixes the regression it introduced where customProps wouldn't be set until the response was sent (if you were using customReceiveMessage or just any other logging on your server).
The downsides are the customProps gets called twice, but it feels worth it to me personally.