Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add autologging ignore option #153

Merged
merged 1 commit into from
Aug 21, 2021
Merged

add autologging ignore option #153

merged 1 commit into from
Aug 21, 2021

Conversation

naseemkullah
Copy link
Contributor

@naseemkullah naseemkullah commented Aug 20, 2021 •
edited
Loading

solves #107 via a generic autologging.ignore function

I get errors locally when trying to test: Unexpected var, use let or const instead., linting fixes it (npm run fix) but have reverted the linting as requested

mcollina
mcollina requested changes Aug 20, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please restore all the spurious changes? There is a lot of var -> const/let migration here.

@naseemkullah
Copy link
Contributor Author

Can you please restore all the spurious changes? There is a lot of var -> const/let migration here.

linting reverted, but tests fail locally (and in CI)

mcollina
mcollina approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@naseemkullah naseemkullah changed the title run fix and add autologging ignore option add autologging ignore option Aug 20, 2021
@mcollina
Copy link
Member

CI is failing because:

  /home/runner/work/pino-http/pino-http/logger.js:122:11: 'autoLoggingIgnore' is not defined.
61
  /home/runner/work/pino-http/pino-http/logger.js:123:27: 'autoLoggingIgnore' is not defined.
62
  /home/runner/work/pino-http/pino-http/logger.js:123:57: 'autoLoggingIgnore' is not defined.

@naseemkullah
Copy link
Contributor Author

naseemkullah commented Aug 21, 2021 •
edited
Loading

CI is failing because:

  /home/runner/work/pino-http/pino-http/logger.js:122:11: 'autoLoggingIgnore' is not defined.
61
  /home/runner/work/pino-http/pino-http/logger.js:123:27: 'autoLoggingIgnore' is not defined.
62
  /home/runner/work/pino-http/pino-http/logger.js:123:57: 'autoLoggingIgnore' is not defined.

Oops, thanks. Fixing now.

@mcollina mcollina merged commit 7415dad into pinojs:master Aug 21, 2021
@naseemkullah naseemkullah deleted the autologging-ignore branch August 21, 2021 17:10
@naseemkullah naseemkullah mentioned this pull request Aug 21, 2021
Closed
naseemkullah added a commit to naseemkullah/DefinitelyTyped that referenced this pull request Aug 21, 2021
@naseemkullah
pino-http: add autlogging ignore type
9efb97f 
autologgin ignore was just introduced in pino 5.7.0 via pinojs/pino-http#153
naseemkullah added a commit to naseemkullah/DefinitelyTyped that referenced this pull request Aug 21, 2021
@naseemkullah
pino-http: add autlogging ignore type
deced03 
autologging ignore was just introduced in pino 5.7.0 via pinojs/pino-http#153
@naseemkullah naseemkullah mentioned this pull request Aug 21, 2021
Merged
naseemkullah added a commit to naseemkullah/DefinitelyTyped that referenced this pull request Aug 21, 2021
@naseemkullah
pino-http: add autologging ignore type
cf1dcde 
autologging ignore was just introduced in pino 5.7.0 via pinojs/pino-http#153
naseemkullah added a commit to naseemkullah/DefinitelyTyped that referenced this pull request Aug 21, 2021
@naseemkullah
pino-http: add autologging ignore type
660038f 
autologging ignore was just introduced in pino 5.7.0 via pinojs/pino-http#153
typescript-bot pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Aug 23, 2021
@naseemkullah
🤖 Merge PR #55285 pino-http: add autologging ignore type by @naseemku…
4da2443 
…llah

autologging ignore was just introduced in pino 5.7.0 via pinojs/pino-http#153
@naseemkullah naseemkullah mentioned this pull request Jan 15, 2022
Merged
7 tasks
@peterleiva peterleiva mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naseemkullah @mcollina