feat: log even on closed connections #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Nov 7, 2020
| this.removeListener('finish', onResFinished) | ||
| >>>>>>> Stashed changes |
There was a problem hiding this comment.
It seems you have made some git mistakes :). Would you mind to fix them?
There was a problem hiding this comment.
@dalexanco feel free to send a fresh PR if you'd like.
There was a problem hiding this comment.
@mcollina: #123
@dalexanco: I really wanted to get this merged upstream, so, I checked out your branch and committed the fix with you as the co-author; all your other commits are left intact. Thanks for the fix!
There was a problem hiding this comment.
my bad, I have been away for a while.
Thank you for the 2nd PR !
Really smart to allow the feature only on v12, that was the real reason of my absence on this PR : I fail to make it work on v10 😅
|
closed for no activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR change the event used by pino-http on response from 'finish' to 'close'.
It let the opportunity to log request which does not have open socket anymore.
I add a new option "onlyLogFinishedRequest" set by default to true (to keep existing behavior).
More information : #116