-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load config from pino on startup #90
Merged
mcollina
merged 4 commits into
pinojs:main
from
10xLaCroixDrinker:feature/load-config-from-pino
Apr 22, 2024
Merged
feat: load config from pino on startup #90
mcollina
merged 4 commits into
pinojs:main
from
10xLaCroixDrinker:feature/load-config-from-pino
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2024
Pull Request Test Coverage Report for Build 8396963026Details
💛 - Coveralls |
jsumners
reviewed
Apr 6, 2024
Co-authored-by: James Sumners <[email protected]>
mcollina
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
renovate bot
referenced
this pull request
in redwoodjs/redwood
May 16, 2024
) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-abstract-transport](https://togithub.com/pinojs/pino-abstract-transport) | [`1.1.0` -> `1.2.0`](https://renovatebot.com/diffs/npm/pino-abstract-transport/1.1.0/1.2.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-abstract-transport (pino-abstract-transport)</summary> ### [`v1.2.0`](https://togithub.com/pinojs/pino-abstract-transport/releases/tag/v1.2.0) [Compare Source](https://togithub.com/pinojs/pino-abstract-transport/compare/v1.1.0...v1.2.0) #### What's Changed - build(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/80](https://togithub.com/pinojs/pino-abstract-transport/pull/80) - build(deps): bump actions/setup-node from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/82](https://togithub.com/pinojs/pino-abstract-transport/pull/82) - build(deps-dev): bump tsd from 0.28.1 to 0.30.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/83](https://togithub.com/pinojs/pino-abstract-transport/pull/83) - build(deps-dev): bump husky from 8.0.3 to 9.0.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/84](https://togithub.com/pinojs/pino-abstract-transport/pull/84) - build(deps): bump actions/cache from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/85](https://togithub.com/pinojs/pino-abstract-transport/pull/85) - docs(readme): fix broken badge URLs by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino-abstract-transport/pull/88](https://togithub.com/pinojs/pino-abstract-transport/pull/88) - refactor: remove objectMode argument as it is ignored by Duplex.from by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino-abstract-transport/pull/89](https://togithub.com/pinojs/pino-abstract-transport/pull/89) - build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/91](https://togithub.com/pinojs/pino-abstract-transport/pull/91) - feat: load config from pino on startup by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino-abstract-transport/pull/90](https://togithub.com/pinojs/pino-abstract-transport/pull/90) - Make the tests compatible with Node 18 and 20 by [@​donwellus](https://togithub.com/donwellus) in [https://github.com/pinojs/pino-abstract-transport/pull/94](https://togithub.com/pinojs/pino-abstract-transport/pull/94) #### New Contributors - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/pinojs/pino-abstract-transport/pull/88](https://togithub.com/pinojs/pino-abstract-transport/pull/88) - [@​donwellus](https://togithub.com/donwellus) made their first contribution in [https://github.com/pinojs/pino-abstract-transport/pull/94](https://togithub.com/pinojs/pino-abstract-transport/pull/94) **Full Changelog**: pinojs/pino-abstract-transport@v1.1.0...v1.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Josh-Walker-GM
referenced
this pull request
in redwoodjs/redwood
May 17, 2024
) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-abstract-transport](https://togithub.com/pinojs/pino-abstract-transport) | [`1.1.0` -> `1.2.0`](https://renovatebot.com/diffs/npm/pino-abstract-transport/1.1.0/1.2.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-abstract-transport (pino-abstract-transport)</summary> ### [`v1.2.0`](https://togithub.com/pinojs/pino-abstract-transport/releases/tag/v1.2.0) [Compare Source](https://togithub.com/pinojs/pino-abstract-transport/compare/v1.1.0...v1.2.0) #### What's Changed - build(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/80](https://togithub.com/pinojs/pino-abstract-transport/pull/80) - build(deps): bump actions/setup-node from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/82](https://togithub.com/pinojs/pino-abstract-transport/pull/82) - build(deps-dev): bump tsd from 0.28.1 to 0.30.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/83](https://togithub.com/pinojs/pino-abstract-transport/pull/83) - build(deps-dev): bump husky from 8.0.3 to 9.0.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/84](https://togithub.com/pinojs/pino-abstract-transport/pull/84) - build(deps): bump actions/cache from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/85](https://togithub.com/pinojs/pino-abstract-transport/pull/85) - docs(readme): fix broken badge URLs by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino-abstract-transport/pull/88](https://togithub.com/pinojs/pino-abstract-transport/pull/88) - refactor: remove objectMode argument as it is ignored by Duplex.from by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino-abstract-transport/pull/89](https://togithub.com/pinojs/pino-abstract-transport/pull/89) - build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-abstract-transport/pull/91](https://togithub.com/pinojs/pino-abstract-transport/pull/91) - feat: load config from pino on startup by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino-abstract-transport/pull/90](https://togithub.com/pinojs/pino-abstract-transport/pull/90) - Make the tests compatible with Node 18 and 20 by [@​donwellus](https://togithub.com/donwellus) in [https://github.com/pinojs/pino-abstract-transport/pull/94](https://togithub.com/pinojs/pino-abstract-transport/pull/94) #### New Contributors - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/pinojs/pino-abstract-transport/pull/88](https://togithub.com/pinojs/pino-abstract-transport/pull/88) - [@​donwellus](https://togithub.com/donwellus) made their first contribution in [https://github.com/pinojs/pino-abstract-transport/pull/94](https://togithub.com/pinojs/pino-abstract-transport/pull/94) **Full Changelog**: pinojs/pino-abstract-transport@v1.1.0...v1.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 3 of 3 for pinojs/pino#1925
Relates to pinojs/thread-stream#145
Relates to pinojs/pino#1930
This still requires some changes to types. New overloads need to be added since it conditionally returns a Promise.