Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed failing test and added other test branch #65

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fixed failing test and added other test branch #65

merged 3 commits into from
Nov 20, 2023

Conversation

big-kahuna-burger
Copy link

@big-kahuna-burger big-kahuna-burger commented Nov 10, 2023 •
edited
Loading

Closes #63

Looking into work done in #64 and comments there, I've found out the issue with and without flushing headers.

  • added extra test so both cases are tested
  • refactored duplicated http calls for error path into a function
  • removed support for older runtimes

@big-kahuna-burger
Copy link
Author

@Fdawgs @mcollina do you want to let the action run on this one please?

mcollina
mcollina approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a4488dc into pinojs:next Nov 20, 2023
7 checks passed
@big-kahuna-burger
Copy link
Author

Merging this makes #64 obsolete so you might want to close that.

@Ranieri93 Ranieri93 mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-kahuna-burger @mcollina