Load assets not specified protocol

[nWidart]

Hello,

Could you please load assets without specifying http://, for instance:

Example:

Module::asset(''core:js/keypressAction.js)

Don't load:

<script src="http://asgardcms.dev/modules/core/js/keypressAction.js" type="text/javascript"></script>

but:

<script src="//asgardcms.dev/modules/core/js/keypressAction.js" type="text/javascript"></script>

This will load the asset to the current protocol, either http or https.

You could also provide an optional argument, in addition to loading assets over //, to set secure true or false.

Thanks!

(This is pretty important since loading the site over https will fail because of this issue)

[nWidart]

I just saw there is a secure = false argument to the Asset:: helper.
Maybe there's a way of making this // by default.
I know https://github.com/floatingpointsoftware/stylist does this, their assets are loading using //asset/asset.css

[nWidart]

I updated the package, using "pingpong/modules": "~2.0", , instead of the previous 2.0.*@dev one.

After update, I'm getting:

[Symfony\Component\Debug\Exception\FatalErrorException]  
  Class 'Pingpong\Support\Stub' not found                  

The full stacktrace:

[22-May-2015 06:01:02 UTC] PHP Fatal error:  Class 'Pingpong\Support\Stub' not found in /Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/pingpong/modules/ModulesServiceProvider.php on line 48
[22-May-2015 06:01:02 UTC] PHP Stack trace:
[22-May-2015 06:01:02 UTC] PHP   1. {main}() /Users/nicolaswidart/Sites/Asguard/presentation-site/artisan:0
[22-May-2015 06:01:02 UTC] PHP   2. Illuminate\Foundation\Console\Kernel->handle() /Users/nicolaswidart/Sites/Asguard/presentation-site/artisan:36
[22-May-2015 06:01:02 UTC] PHP   3. Illuminate\Foundation\Console\Kernel->bootstrap() /Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:92
[22-May-2015 06:01:02 UTC] PHP   4. Illuminate\Foundation\Application->bootstrapWith() /Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:195
[22-May-2015 06:01:02 UTC] PHP   5. Illuminate\Foundation\Bootstrap\BootProviders->bootstrap() /Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:183
[22-May-2015 06:01:02 UTC] PHP   6. Illuminate\Foundation\Application->boot() /Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/BootProviders.php:15
[22-May-2015 06:01:02 UTC] PHP   7. Illuminate\Foundation\Application->fireAppCallbacks() /Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:690
[22-May-2015 06:01:02 UTC] PHP   8. call_user_func:{/Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:862}() /Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:862
[22-May-2015 06:01:02 UTC] PHP   9. Pingpong\Modules\ModulesServiceProvider->Pingpong\Modules\{closure}() /Users/nicolaswidart/Sites/Asguard/presentation-site/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:862

[nWidart]

When I try to go back to the @dev version, I'm getting

Nothing to install or update
Writing lock file
Generating autoload files

Plus the error mentioned above.

[gravitano]

Which version are you use ?

[nWidart]

~2.0 and 2.0.*@dev both have this issue.

[gravitano]

Hmm.. Make sure get version 2.0.7 (the latest version). You can see in version 2.0.7 I've added pingpong/support to the require block https://github.com/pingpong-labs/modules/blob/2.0.7/composer.json#L22.

[nWidart]

I am on version 2.0.7...

I just removed the vendor folder, to be sure nothing is in cache, ran a new composer update, and I'm still getting this error.

When looking at the ModulesServiceProvider, Pingpong\Support\Stub does not exist.

[nWidart]

Also, when I check pingpong/support, I don't see that Stub class.

[nWidart]

I see version 2.0.3 of pingpong/support is installed, which doesn't have that stub class: https://github.com/pingpong-labs/support/tree/2.0.3

[nWidart]

I now manually added "pingpong/support": "~2.0", to the main composer.json file, so that it's gets the 2.0.6 version, and that seems to work.

But I shouldn't have to add it myself though.

[nWidart]

Using 2.0.*@dev I cannot seem to get your change of today though, concernant the // protocol of assets.

[gravitano]

Just tagged this package to new version 2.0.8. Try upgrade.

[nWidart]

okay thanks. Do I still need to explicitly specify "pingpong/support": "~2.0", in my composer.json file ?

[gravitano]

No. pingpong/support has been included (require) by pingpong/modules package.

[nWidart]

Okay, I removed pingpong/support from vendor folder to be sure it's included, though I still get

 [Symfony\Component\Debug\Exception\FatalErrorException]  
  Class 'Pingpong\Support\Stub' not found 

Again, when I add "pingpong/support": "~2.0", manually in my composer.json file, then and only then, it works.