Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pingone_environment: Deprecate the default population configuration #485

Conversation

patrickcping
Copy link
Collaborator

@patrickcping patrickcping commented Jul 20, 2023

Change Description

Progresses #462

  • resource/pingone_environment: Deprecated the default_population block and default_population_id attribute in favour of the new pingone_population_default resource.
  • resource/pingone_environment: Removed the ability to import the resource including a default population. Default populations are now managed with the pingone_population_default resource.

Testing Results

Testing Shell Command

TF_ACC=1 go test -v -timeout 500s -run ^TestAccEnvironment_ github.com/pingidentity/terraform-provider-pingone/internal/service/base

Testing Results

=== RUN   TestAccEnvironment_RemovalDrift
=== PAUSE TestAccEnvironment_RemovalDrift
=== RUN   TestAccEnvironment_Full
=== PAUSE TestAccEnvironment_Full
=== RUN   TestAccEnvironment_Minimal
=== PAUSE TestAccEnvironment_Minimal
=== RUN   TestAccEnvironment_NonCompatibleRegion
=== PAUSE TestAccEnvironment_NonCompatibleRegion
=== RUN   TestAccEnvironment_DeleteProductionEnvironmentProtection
=== PAUSE TestAccEnvironment_DeleteProductionEnvironmentProtection
=== RUN   TestAccEnvironment_DeleteProductionEnvironment
=== PAUSE TestAccEnvironment_DeleteProductionEnvironment
=== RUN   TestAccEnvironment_MinimalWithPopulation
=== PAUSE TestAccEnvironment_MinimalWithPopulation
=== RUN   TestAccEnvironment_EnvironmentTypeSwitching
=== PAUSE TestAccEnvironment_EnvironmentTypeSwitching
=== RUN   TestAccEnvironment_ServiceSwitching
=== PAUSE TestAccEnvironment_ServiceSwitching
=== RUN   TestAccEnvironment_Services
=== PAUSE TestAccEnvironment_Services
=== RUN   TestAccEnvironment_BadParameters
=== PAUSE TestAccEnvironment_BadParameters
=== CONT  TestAccEnvironment_RemovalDrift
=== CONT  TestAccEnvironment_MinimalWithPopulation
=== CONT  TestAccEnvironment_Minimal
=== CONT  TestAccEnvironment_Services
=== CONT  TestAccEnvironment_ServiceSwitching
=== CONT  TestAccEnvironment_Full
=== CONT  TestAccEnvironment_EnvironmentTypeSwitching
=== CONT  TestAccEnvironment_DeleteProductionEnvironment
=== CONT  TestAccEnvironment_DeleteProductionEnvironmentProtection
=== CONT  TestAccEnvironment_NonCompatibleRegion
=== CONT  TestAccEnvironment_BadParameters
=== NAME  TestAccEnvironment_DeleteProductionEnvironment
    resource_environment_test.go:294: Test to be defined
--- SKIP: TestAccEnvironment_DeleteProductionEnvironment (0.00s)
=== NAME  TestAccEnvironment_DeleteProductionEnvironmentProtection
    resource_environment_test.go:267: Test to be defined
--- SKIP: TestAccEnvironment_DeleteProductionEnvironmentProtection (0.00s)
--- PASS: TestAccEnvironment_NonCompatibleRegion (2.03s)
--- PASS: TestAccEnvironment_RemovalDrift (5.69s)
--- PASS: TestAccEnvironment_Minimal (7.24s)
--- PASS: TestAccEnvironment_BadParameters (7.71s)
--- PASS: TestAccEnvironment_MinimalWithPopulation (7.78s)
--- PASS: TestAccEnvironment_ServiceSwitching (13.63s)
--- PASS: TestAccEnvironment_EnvironmentTypeSwitching (14.97s)
--- PASS: TestAccEnvironment_Full (15.58s)
--- PASS: TestAccEnvironment_Services (23.79s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/base        24.669s

@patrickcping patrickcping self-assigned this Jul 20, 2023
@patrickcping
Copy link
Collaborator Author

Blocked by #330

@patrickcping patrickcping added this to the v0.20.0 milestone Jul 25, 2023
@patrickcping patrickcping modified the milestones: v0.20.0, v0.21.0 Aug 3, 2023
@patrickcping patrickcping modified the milestones: v0.21.0, v0.22.0 Sep 15, 2023
@patrickcping patrickcping modified the milestones: v0.22.0, v0.23.0 Oct 2, 2023
@patrickcping patrickcping added the service/base PingOne Platform label Oct 24, 2023
@patrickcping patrickcping marked this pull request as ready for review October 24, 2023 11:52
@patrickcping patrickcping merged commit ff73c83 into main Oct 24, 2023
28 checks passed
@patrickcping patrickcping deleted the migrate-default-population-from-environment-to-own-resource-202307 branch October 24, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change service/base PingOne Platform type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant