Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement ability to import resource state #196

Merged
merged 14 commits into from
Oct 25, 2023

Conversation

patrickcping
Copy link
Contributor

@patrickcping patrickcping commented Aug 24, 2023

Change Description

Testing Results

Testing Shell Command

TF_ACC=1 go test -v -timeout 2400s -run ^ github.com/pingidentity/terraform-provider-davinci/internal/service/davinci

Testing Results

=== RUN   TestAccDatasourceApplication_SlimByAppId
--- PASS: TestAccDatasourceApplication_SlimByAppId (57.23s)
=== RUN   TestAccDatasourceApplication_SlimById
--- PASS: TestAccDatasourceApplication_SlimById (54.95s)
=== RUN   TestAccDataSourceApplications_AllApplications
--- PASS: TestAccDataSourceApplications_AllApplications (60.11s)
=== RUN   TestAccDataSourceConnection_ReadAllAT
--- PASS: TestAccDataSourceConnection_ReadAllAT (17.56s)
=== RUN   TestAccDataSourceConnection_ReadSingle
--- PASS: TestAccDataSourceConnection_ReadSingle (55.01s)
=== RUN   TestAccDataSourceConnection_ReadSingleByName
--- PASS: TestAccDataSourceConnection_ReadSingleByName (56.01s)
=== RUN   TestAccDataSourceConnection_AllConections
--- PASS: TestAccDataSourceConnection_AllConections (50.16s)
=== RUN   TestAccDataSourceConnection_FilteredConnections
--- PASS: TestAccDataSourceConnection_FilteredConnections (48.71s)
=== RUN   TestAccResourceApplication_Slim
--- PASS: TestAccResourceApplication_Slim (55.66s)
=== RUN   TestAccResourceApplication_WithFlowPolicy
--- PASS: TestAccResourceApplication_WithFlowPolicy (82.63s)
=== RUN   TestAccResourceApplication_P1SessionFlowPolicy
--- PASS: TestAccResourceApplication_P1SessionFlowPolicy (94.12s)
=== RUN   TestAccResourceApplication_BadParameters
--- PASS: TestAccResourceApplication_BadParameters (71.95s)
=== RUN   TestAccResourceConnection_Slim
--- PASS: TestAccResourceConnection_Slim (58.25s)
=== RUN   TestAccResourceConnection_SlimWithUpdate
--- PASS: TestAccResourceConnection_SlimWithUpdate (66.33s)
=== RUN   TestAccResourceConnection_HeavyRead
--- PASS: TestAccResourceConnection_HeavyRead (349.65s)
=== RUN   TestAccResourceConnection_BadParameters
--- PASS: TestAccResourceConnection_BadParameters (73.02s)
=== RUN   TestAccResourceFlow_SimpleFlow
--- PASS: TestAccResourceFlow_SimpleFlow (54.98s)
=== RUN   TestAccResourceFlow_SimpleFlowUpdate
--- PASS: TestAccResourceFlow_SimpleFlowUpdate (79.94s)
=== RUN   TestAccResourceFlow_SubFlows
--- PASS: TestAccResourceFlow_SubFlows (99.75s)
=== RUN   TestAccResourceFlow_VariableConnectorFlow
    resource_flow_test.go:221: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
                "flow_json": strings.Join({
                        ... // 191 identical bytes
                        `16:09:25 GMT+0000 (Coordinated Universal Time)","createdDate":16`,
                        `92893365739,"updatedDate":1692893366401,"deployedDate":169289336`,
        -               "6401",
        +               "5804",
                        `,"trigger":{},"timeouts":"null","flowId":"ea92a4b81fb1362dab6ef2`,
                        `9a857086a4","companyId":"03898103-53d4-417a-b626-968cd00ffb87","`,
                        ... // 3145 identical bytes
                }, ""),
          }
--- FAIL: TestAccResourceFlow_VariableConnectorFlow (64.72s)
=== RUN   TestAccResourceFlow_BrokenFlow
--- PASS: TestAccResourceFlow_BrokenFlow (45.08s)
=== RUN   TestAccResourceFlow_SchemaChanges
--- PASS: TestAccResourceFlow_SchemaChanges (144.67s)
=== RUN   TestAccResourceFlow_FlowContextVarFlow
--- PASS: TestAccResourceFlow_FlowContextVarFlow (54.04s)
=== RUN   TestAccResourceFlow_BadParameters
--- PASS: TestAccResourceFlow_BadParameters (73.59s)
=== RUN   TestAccResourceVariable_CompanyContext
--- PASS: TestAccResourceVariable_CompanyContext (59.06s)
=== RUN   TestAccResourceVariable_FlowInstanceContext
--- PASS: TestAccResourceVariable_FlowInstanceContext (59.19s)
=== RUN   TestAccResourceVariable_BadParameters
--- PASS: TestAccResourceVariable_BadParameters (72.45s)
FAIL
FAIL    github.com/pingidentity/terraform-provider-davinci/internal/service/davinci     2059.391s
FAIL

@patrickcping patrickcping linked an issue Aug 24, 2023 that may be closed by this pull request
@patrickcping patrickcping changed the title Fix implementation of importing resources Re-implement ability to import resource state Aug 24, 2023
@patrickcping
Copy link
Contributor Author

@samir-gandhi need to review the test failure to see what we can do about it, but in the meantime feel free to code review

@samir-gandhi samir-gandhi marked this pull request as ready for review October 25, 2023 21:02
@samir-gandhi samir-gandhi merged commit 220730c into main Oct 25, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HOUSEKEEPING] Add terraform import tests
2 participants