-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement ability to import resource state #196
Merged
samir-gandhi
merged 14 commits into
main
from
192-housekeeping-add-terraform-import-tests
Oct 25, 2023
Merged
Re-implement ability to import resource state #196
samir-gandhi
merged 14 commits into
main
from
192-housekeeping-add-terraform-import-tests
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickcping
changed the title
Fix implementation of importing resources
Re-implement ability to import resource state
Aug 24, 2023
… resource state.
…rm-import-examples-so-they-are-shown-in-documentation Added `terraform import` documentation to all applicable resources.
patrickcping
commented
Aug 24, 2023
patrickcping
commented
Aug 24, 2023
patrickcping
commented
Aug 24, 2023
@samir-gandhi need to review the test failure to see what we can do about it, but in the meantime feel free to code review |
samir-gandhi
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
terraform import
documentation to all applicable resources. #195 )Testing Results
Testing Shell Command
TF_ACC=1 go test -v -timeout 2400s -run ^ github.com/pingidentity/terraform-provider-davinci/internal/service/davinci
Testing Results