Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove omitempty for node properties on go client. #32

Closed
samir-gandhi opened this issue Feb 3, 2023 · 0 comments
Closed

Remove omitempty for node properties on go client. #32

samir-gandhi opened this issue Feb 3, 2023 · 0 comments
Labels

Comments

@samir-gandhi
Copy link
Contributor

https://github.com/samir-gandhi/davinci-client-go/blob/main/davinci/models_flows.go#L49

Davinci Flows seem to keep empty properties object in json "properties": {} rather than remove field on nodes with no properties - This was tested with fingerprintjs

samir-gandhi added a commit that referenced this issue Feb 7, 2023
@samir-gandhi samir-gandhi mentioned this issue Feb 7, 2023
samir-gandhi added a commit that referenced this issue Feb 7, 2023
* closes:
- issue #29 
- issue #30 
- issue #32 
- issue #33 
- issue #35 
- issue #40 
- issue #45 
- issue #47 

* Bump goreleaser/goreleaser-action from 4.1.0 to 4.2.0

Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](goreleaser/goreleaser-action@v4.1.0...v4.2.0)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* closes issue #30 and issue #32

* Bump github.com/golangci/golangci-lint from 1.50.1 to 1.51.1

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.50.1 to 1.51.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.50.1...v1.51.1)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* stashing work before tests

* closes:
- issue 32
- issue 33
- issue 40
- issue 45
- issue 47

* changelog for issue 29

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant