Enhance/cache pd status #986
Conversation
ti-chi-bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
=======================================
Coverage 55.64% 55.65%
=======================================
Files 279 279
Lines 19715 19743 +28
=======================================
+ Hits 10970 10987 +17
- Misses 7037 7044 +7
- Partials 1708 1712 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9547
force-pushed
the
feature/cache-pd-status
branch
from
895545e to
3c20b65
Compare
|
Hi, could you update your PR description about the Dashboard URL change? |
Sorry, and I'll add it in the |
Actually I only want to know what it looks like in the terminal output for this Dashbaord URL change :) |
AstroProfundis
added
the
category/usability
|
@breeswish PTAL root@control:/tiup-cluster# tiup-cluster display xxx
Cluster type: tidb
Cluster name: xxx
Cluster version: v4.0.4
SSH type: builtin
Dashboard URL: http://n5:2379/dashboard
ID Role Host Ports OS/Arch Status Data Dir Deploy Dir
... |
|
Maybe we can remove the |
LGTM |
|
/lgtm |
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
Can merge label has been added. Git tree hash: 9590b25
|
* typo(cluster/pdapi): misused arg name * enhance(cluster/pd): pd.Status check by itself * feat(cluster/spec): add GetDashardAddress * enhance(utils): set http clien't dial timeout to 5second * feat(cluster/manager): cache pd's status * feat(cluster/manager): display dashboard url * tests(cluster): add display result check * feat(dm): get master's status by local host * feat(cluster/manager): cache dm's master status * feat(cluster/manager): highlight display dm's status * feat(cluster/manager): highlight display dm's status * refact(cluster/pd): rm notused suffix * typo(spec/cluster): UP -> Up Co-authored-by: SIGSEGV <[email protected]>
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
The old one need ~2minutes
After cached, the used time is limited in 3*10s
One more thing
for the dm's cluster, I've highlighted the dm's status code, similar to tidb-cluster's, like below:
And if dm-masters were down, the dm-workers' status previous as below:
after this or, changed to: (Down -> N/A, means worker's status depends on master, but all masters were down)
Dashboard url
display with dashboard-url appended
root@control:/tiup-cluster# tiup-cluster display xxx Cluster type: tidb Cluster name: xxx Cluster version: v4.0.4 SSH type: builtin Dashboard URL: http://n5:2379/dashboard ID Role Host Ports OS/Arch Status Data Dir Deploy Dir ...Code changes
Side effects
Related changes
Release notes: