Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless errors.AddStack #985

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Conversation

lucklove
Copy link
Member

Fix #721

What problem does this PR solve?

Remove redundant errors.AddStack

What is changed and how it works?

errors.AddStack(err) -> err

Check List

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested review from lonng and nrc December 11, 2020 10:56
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 11, 2020
@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #985 (388d740) into master (e921248) will decrease coverage by 3.85%.
The diff coverage is 2.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   55.49%   51.64%   -3.86%     
==========================================
  Files         279      279              
  Lines       19709    19709              
==========================================
- Hits        10937    10178     -759     
- Misses       7055     7896     +841     
+ Partials     1717     1635      -82     
Flag Coverage Δ
cluster 38.11% <1.02%> (-5.25%) ⬇️
dm 23.81% <0.00%> (-0.02%) ⬇️
integrate 45.89% <1.18%> (-3.87%) ⬇️
playground 20.29% <0.00%> (ø)
tiup 16.45% <2.38%> (ø)
unittest 23.08% <2.96%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/check.go 6.27% <0.00%> (-73.27%) ⬇️
components/cluster/command/display.go 27.41% <0.00%> (ø)
components/cluster/command/import.go 17.64% <0.00%> (ø)
components/cluster/command/test.go 40.35% <0.00%> (-19.30%) ⬇️
components/dm/ansible/import.go 62.69% <0.00%> (ø)
components/dm/command/import.go 19.35% <0.00%> (ø)
components/dm/command/scale_in.go 60.60% <0.00%> (ø)
components/playground/command.go 79.59% <0.00%> (ø)
components/playground/grafana.go 77.11% <0.00%> (ø)
components/playground/main.go 72.30% <0.00%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e921248...388d740. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2020
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 388d740

@pingcap pingcap deleted a comment from ti-chi-bot Dec 14, 2020
@ti-chi-bot ti-chi-bot merged commit 01bf92c into pingcap:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify repository error handling
4 participants