Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cluster): quote surround wildcard #982

Merged
merged 10 commits into from
Dec 15, 2020

Conversation

9547
Copy link
Contributor

@9547 9547 commented Dec 10, 2020

What problem does this PR solve?

fix #974

What is changed and how it works?

Check List

Tests
Manual test:

before fix

image

after fix

success

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 10, 2020
@codecov-io
Copy link

codecov-io commented Dec 10, 2020

Codecov Report

Merging #982 (3c98ed3) into master (d36a601) will decrease coverage by 2.61%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   54.37%   51.75%   -2.62%     
==========================================
  Files         279      279              
  Lines       19716    19709       -7     
==========================================
- Hits        10721    10201     -520     
- Misses       7314     7889     +575     
+ Partials     1681     1619      -62     
Flag Coverage Δ
cluster 38.35% <18.18%> (-2.65%) ⬇️
dm 23.85% <63.63%> (-0.02%) ⬇️
integrate 46.07% <63.63%> (-2.51%) ⬇️
playground 20.28% <ø> (ø)
tiup 16.46% <0.00%> (+0.01%) ⬆️
unittest 23.09% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/prometheus.go 68.21% <45.45%> (+1.32%) ⬆️
pkg/cluster/spec/grafana.go 68.00% <81.81%> (+3.65%) ⬆️
components/cluster/command/check.go 6.27% <0.00%> (-73.27%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-52.54%) ⬇️
pkg/cluster/manager/patch.go 0.00% <0.00%> (-51.81%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/operation/operation.go 34.78% <0.00%> (-43.48%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36a601...3c98ed3. Read the comment docs.

.github/workflows/integrate-cluster-cmd.yaml Outdated Show resolved Hide resolved
pkg/cluster/spec/grafana.go Outdated Show resolved Hide resolved
pkg/cluster/spec/grafana.go Outdated Show resolved Hide resolved
pkg/cluster/spec/prometheus.go Outdated Show resolved Hide resolved
pkg/cluster/spec/prometheus.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2020
pkg/cluster/spec/prometheus.go Outdated Show resolved Hide resolved
pkg/cluster/spec/prometheus.go Outdated Show resolved Hide resolved
pkg/cluster/spec/grafana.go Outdated Show resolved Hide resolved
@9547
Copy link
Contributor Author

9547 commented Dec 14, 2020

@lucklove PTAL

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2020
@lucklove
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 15, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 3c98ed3

@ti-chi-bot ti-chi-bot merged commit efcaf79 into pingcap:master Dec 15, 2020
@King-Dylan King-Dylan mentioned this pull request Dec 18, 2020
lucklove added a commit to lucklove/tiup that referenced this pull request Jan 11, 2021
lucklove added a commit to lucklove/tiup that referenced this pull request Jan 11, 2021
ti-chi-bot added a commit that referenced this pull request Jan 12, 2021
lucklove added a commit that referenced this pull request Jan 28, 2021
@9547 9547 deleted the fix/zsh-wildcard branch April 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy failed when init config for prometheus and granfana when remote is using zsh
5 participants