Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: omit debug log from console output #977

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Debug logs are not supposed to print on console (stdout), instead, they are more reasonable to be in audit log records.

Also fix #959

What is changed and how it works?

  • Not printing debug info to console
  • Change the default log level of audit logger

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has persistent data change

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: remove debug log from console output

@AstroProfundis AstroProfundis added type/bug-fix Categorizes PR as a bug-fix category/usability Categorizes issue or PR as a usability enhancement. labels Dec 9, 2020
@AstroProfundis AstroProfundis self-assigned this Dec 9, 2020
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 9, 2020
@codecov-io
Copy link

codecov-io commented Dec 9, 2020

Codecov Report

Merging #977 (ffbc9a2) into master (250c47b) will increase coverage by 0.59%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
+ Coverage   55.40%   55.99%   +0.59%     
==========================================
  Files         263      263              
  Lines       19854    19645     -209     
==========================================
+ Hits        11000    11001       +1     
+ Misses       7129     6919     -210     
  Partials     1725     1725              
Flag Coverage Δ
cluster 43.60% <50.00%> (+0.02%) ⬆️
dm 24.17% <50.00%> (-0.07%) ⬇️
integrate 50.22% <50.00%> (+<0.01%) ⬆️
playground 20.57% <ø> (+<0.01%) ⬆️
tiup 16.79% <ø> (+<0.01%) ⬆️
unittest 22.94% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/playground.go 41.63% <ø> (+11.07%) ⬆️
pkg/cluster/manager.go 67.66% <0.00%> (ø)
pkg/logger/log/log.go 100.00% <ø> (ø)
pkg/logger/audit.go 53.33% <100.00%> (ø)
pkg/cluster/api/dmapi.go 58.26% <0.00%> (-1.74%) ⬇️
pkg/cluster/api/pdapi.go 59.13% <0.00%> (+0.61%) ⬆️
pkg/utils/http_client.go 72.22% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 250c47b...77649a5. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.2.6 milestone Dec 9, 2020
@lucklove
Copy link
Member

lucklove commented Dec 9, 2020

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2020
@lucklove
Copy link
Member

lucklove commented Dec 9, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: ffbc9a2

@ti-chi-bot
Copy link
Member

@AstroProfundis: Your PR has out-of-dated and I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit 15151f1 into pingcap:master Dec 9, 2020
@AstroProfundis AstroProfundis deleted the fix-959 branch December 9, 2020 10:09
@lucklove lucklove modified the milestones: v1.2.6, v1.3.0 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.2.5 - Can you omit the failed warn of the connection pd
4 participants