Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repository: move v0manifest.Version to dedicate package #929

Merged
merged 1 commit into from
Nov 23, 2020
Merged

repository: move v0manifest.Version to dedicate package #929

merged 1 commit into from
Nov 23, 2020

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

This is part (and the initial step) of #906

What is changed and how it works?

Move v0manifest.Version to a dedicated pkgver package to reduce dependencies of v0manifest.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Release notes:

NONE

@AstroProfundis AstroProfundis added the type/enhancement Categorizes issue or PR as related to an enhancement. label Nov 23, 2020
@AstroProfundis AstroProfundis added this to the v1.4.0 milestone Nov 23, 2020
@AstroProfundis AstroProfundis self-assigned this Nov 23, 2020
lucklove
lucklove approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2020
@AstroProfundis AstroProfundis merged commit 9127b21 into pingcap:master Nov 23, 2020
@AstroProfundis AstroProfundis deleted the move-v0manifest-version branch November 23, 2020 10:05
@lucklove lucklove modified the milestones: v1.4.0, v1.3.0 Dec 15, 2020
@AstroProfundis AstroProfundis mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove lucklove approved these changes

Assignees

@AstroProfundis AstroProfundis

Labels
status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AstroProfundis @lucklove @ti-srebot