Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update topology.example.yaml #914

Closed
wants to merge 2 commits into from
Closed

Conversation

2983777417
Copy link

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lucklove
❌ 2983777417
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #914 (320dfb8) into master (bd9a03a) will decrease coverage by 3.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   53.09%   49.89%   -3.20%     
==========================================
  Files         260      248      -12     
  Lines       18941    18526     -415     
==========================================
- Hits        10056     9244     -812     
- Misses       7340     7875     +535     
+ Partials     1545     1407     -138     
Flag Coverage Δ
cluster 45.11% <ø> (ø)
dm 23.39% <ø> (-1.68%) ⬇️
integrate 46.80% <ø> (-0.89%) ⬇️
playground ?
tiup 10.67% <ø> (ø)
unittest 21.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/monitor.go 0.00% <0.00%> (-84.42%) ⬇️
components/playground/command.go 0.00% <0.00%> (-78.44%) ⬇️
components/playground/grafana.go 10.16% <0.00%> (-66.95%) ⬇️
components/playground/main.go 4.00% <0.00%> (-65.50%) ⬇️
components/playground/env.go 0.00% <0.00%> (-57.90%) ⬇️
components/playground/playground.go 0.00% <0.00%> (-41.10%) ⬇️
components/dm/command/edit_config.go 37.50% <0.00%> (-37.50%) ⬇️
components/dm/command/upgrade.go 42.85% <0.00%> (-28.58%) ⬇️
pkg/utils/freeport.go 50.00% <0.00%> (-27.28%) ⬇️
pkg/telemetry/meta.go 60.00% <0.00%> (-20.00%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9a03a...320dfb8. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribute.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2020
@lucklove
Copy link
Member

lucklove commented Nov 17, 2020

Hi~ @2983777417 Could you sign the Contributor License Agreement?

@AstroProfundis AstroProfundis added good-first-issue status/need-info More information or actions need to be fufilled before we can process. labels Nov 23, 2020
@lucklove
Copy link
Member

lucklove commented Dec 1, 2020

/hold

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good-first-issue labels Dec 1, 2020
@glkappe
Copy link
Contributor

glkappe commented Feb 24, 2021

I'm very sorry @2983777417 , this pr is important to me, I will fix it through #1155, please conduct a technical review
@lucklove

@lucklove
Copy link
Member

/close

@ti-chi-bot ti-chi-bot closed this Feb 24, 2021
@ti-chi-bot
Copy link
Member

@lucklove: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member

@2983777417: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. first-time-contributor good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. status/LGT1 Indicates that a PR has LGTM 1. status/need-info More information or actions need to be fufilled before we can process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants