-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update topology.example.yaml #914
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
==========================================
- Coverage 53.09% 49.89% -3.20%
==========================================
Files 260 248 -12
Lines 18941 18526 -415
==========================================
- Hits 10056 9244 -812
- Misses 7340 7875 +535
+ Partials 1545 1407 -138
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribute.
Hi~ @2983777417 Could you sign the Contributor License Agreement? |
/hold |
I'm very sorry @2983777417 , this pr is important to me, I will fix it through #1155, please conduct a technical review |
/close |
@lucklove: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@2983777417: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: