Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labels warning #869

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Fix labels warning #869

merged 2 commits into from
Oct 30, 2020

Conversation

lucklove
Copy link
Member

What problem does this PR solve?

Fix #863

What is changed and how it works?

Skip tiflash and tombstone TiKV while fetch labels

Check List

Tests

  • Manual test (add detailed scripts or steps below)

屏幕快照 2020-10-29 下午7 35 37

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StoreList() seems redundant for me, the GetStores() is called both in StoreList() and GetStoreLabels(), and it's result is iterated multiple times.

Signed-off-by: lucklove <[email protected]>
Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 30, 2020
@codecov-io
Copy link

Codecov Report

Merging #869 into master will decrease coverage by 0.03%.
The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   53.04%   53.00%   -0.04%     
==========================================
  Files         263      263              
  Lines       19038    19030       -8     
==========================================
- Hits        10098    10087      -11     
- Misses       7372     7379       +7     
+ Partials     1568     1564       -4     
Flag Coverage Δ
#cluster 44.83% <65.00%> (-0.14%) ⬇️
#dm 25.26% <0.00%> (+0.01%) ⬆️
#integrate 47.81% <65.00%> (-0.11%) ⬇️
#playground 22.17% <0.00%> (+<0.01%) ⬆️
#tiup 10.78% <0.00%> (+<0.01%) ⬆️
#unittest 20.95% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager.go 65.74% <0.00%> (-0.08%) ⬇️
pkg/cluster/spec/spec.go 88.09% <66.66%> (+0.25%) ⬆️
pkg/cluster/api/pdapi.go 53.25% <80.00%> (+1.25%) ⬆️
pkg/cluster/spec/validate.go 93.53% <100.00%> (-1.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa4ea4...1c26507. Read the comment docs.

@lucklove lucklove merged commit 03dcb4f into pingcap:master Oct 30, 2020
@lucklove lucklove deleted the labels branch October 30, 2020 08:26
lucklove added a commit that referenced this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A warning appears after upgrading to version 1.2.1
4 participants