Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow merge the existing description/workaround in errors.toml #867

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Oct 29, 2020

Signed-off-by: Lonng [email protected]

What problem does this PR solve?

Allow merge the existing description/workaround in errors.toml

What is changed and how it works?

Open the existing errors.toml and merge the description/workaround if the previous error metafile contains these values.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@lonng lonng added the type/enhancement Categorizes issue or PR as related to an enhancement. label Oct 29, 2020
@lonng lonng added this to the v1.2.2 milestone Oct 29, 2020
@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #867 into master will decrease coverage by 31.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #867       +/-   ##
===========================================
- Coverage   53.06%   21.12%   -31.94%     
===========================================
  Files         263      234       -29     
  Lines       19038    17223     -1815     
===========================================
- Hits        10102     3638     -6464     
- Misses       7370    13072     +5702     
+ Partials     1566      513     -1053     
Flag Coverage Δ
#cluster ?
#dm ?
#integrate 10.77% <ø> (-37.17%) ⬇️
#playground ?
#tiup 10.77% <ø> (ø)
#unittest 20.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/meta/paths.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/utils.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/logger/log/log.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/prepare.go 0.00% <0.00%> (-100.00%) ⬇️
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/task/builder.go 0.00% <0.00%> (-97.11%) ⬇️
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d297d...3884d34. Read the comment docs.

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
release note should know what component updated.
and I think the user no need to know about this errdoc-gen

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants