-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow merge the existing description/workaround in errors.toml #867
Conversation
Signed-off-by: Lonng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #867 +/- ##
===========================================
- Coverage 53.06% 21.12% -31.94%
===========================================
Files 263 234 -29
Lines 19038 17223 -1815
===========================================
- Hits 10102 3638 -6464
- Misses 7370 13072 +5702
+ Partials 1566 513 -1053
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
release note should know what component updated.
and I think the user no need to know about this errdoc-gen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Lonng <[email protected]>
Signed-off-by: Lonng [email protected]
What problem does this PR solve?
Allow merge the existing description/workaround in errors.toml
What is changed and how it works?
Open the existing errors.toml and merge the
description
/workaround
if the previous error metafile contains these values.Check List
Tests
Release notes: