-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More safe way to cleanup tombstone nodes #858
Conversation
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
==========================================
- Coverage 53.09% 53.06% -0.04%
==========================================
Files 261 263 +2
Lines 19014 19038 +24
==========================================
+ Hits 10096 10102 +6
- Misses 7358 7370 +12
- Partials 1560 1566 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: lucklove <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Lonng <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
What problem does this PR solve?
With TiUP, if we want to offline a TiKV server, we need do this first:
This will send a request to PD servers to tell them that we want to offline this TiKV server, then PD servers will transfer all regions in this TiKV to some other place. After transferring data, the state of this TiKV server will be tombstone. At this point, the data of this server will be deleted (see the yellow line in the picture below).
But oncel the user execute the
display
command:The TiKV server in tombstone state will be destroyed and cleanup at once, this may confuse users and it's unsafe.
What is changed and how it works?
DO NOT cleanup tombstone TiKV servers in display command, but add a prune command to do this, and give the user a choice to cancel the action:
Check List
Tests
Related changes
Release notes: