Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev doc #837

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Update dev doc #837

merged 2 commits into from
Oct 15, 2020

Conversation

lucklove
Copy link
Member

Fix #829

Check List

Tests

  • No code

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #837 into master will decrease coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   52.95%   52.35%   -0.61%     
==========================================
  Files         261      257       -4     
  Lines       18999    18847     -152     
==========================================
- Hits        10061     9867     -194     
- Misses       7378     7450      +72     
+ Partials     1560     1530      -30     
Flag Coverage Δ
#cluster 44.73% <ø> (-0.06%) ⬇️
#dm 25.23% <ø> (+0.01%) ⬆️
#integrate 48.05% <ø> (+0.28%) ⬆️
#playground 22.17% <ø> (ø)
#tiup ?
#unittest 20.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (-100.00%) ⬇️
cmd/env.go 23.07% <0.00%> (-69.24%) ⬇️
pkg/utils/args.go 0.00% <0.00%> (-50.00%) ⬇️
cmd/uninstall.go 34.54% <0.00%> (-43.64%) ⬇️
cmd/help.go 39.21% <0.00%> (-27.46%) ⬇️
cmd/list.go 12.97% <0.00%> (-25.96%) ⬇️
cmd/install.go 62.50% <0.00%> (-25.00%) ⬇️
cmd/status.go 8.10% <0.00%> (-18.92%) ⬇️
cmd/root.go 42.85% <0.00%> (-18.69%) ⬇️
cmd/clean.go 14.70% <0.00%> (-17.65%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99501f8...c1c0c55. Read the comment docs.

Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2020
@lonng
Copy link
Contributor

lonng commented Oct 15, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 15, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 830

@lonng lonng added this to the v1.2.1 milestone Oct 15, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lucklove merge failed.

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@lucklove lucklove merged commit bfd1d20 into master Oct 15, 2020
@lucklove lucklove deleted the lucklove-patch-1 branch October 15, 2020 13:13
lucklove added a commit that referenced this pull request Oct 23, 2020
Fix #829

Co-authored-by: ti-srebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: instructions to run TiUp as a developer are incomplete/incorrect
5 participants