Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tidb count in error message #821

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Conversation

SwanSpouse
Copy link
Contributor

What problem does this PR solve?

fix tidb count in error message

What is changed and how it works?

error log message

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020

Codecov Report

Merging #821 into master will increase coverage by 3.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
+ Coverage   49.57%   52.71%   +3.14%     
==========================================
  Files         250      262      +12     
  Lines       18557    18971     +414     
==========================================
+ Hits         9199    10000     +801     
+ Misses       7932     7409     -523     
- Partials     1426     1562     +136     
Flag Coverage Δ
#cluster 44.68% <ø> (+0.05%) ⬆️
#dm 25.17% <ø> (+0.28%) ⬆️
#integrate 47.73% <0.00%> (+0.80%) ⬆️
#playground 22.17% <0.00%> (?)
#tiup 10.83% <ø> (ø)
#unittest 18.81% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/playground.go 41.09% <0.00%> (+41.09%) ⬆️
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/instance.go 36.36% <0.00%> (ø)
components/playground/instance/process.go 81.08% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
components/playground/instance/tidb.go 77.14% <0.00%> (ø)
components/playground/instance/tiflash.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash_config.go 0.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d267189...885e393. Read the comment docs.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020
@july2993
Copy link
Contributor

/merge
thanks

@lonng lonng merged commit a23aa1a into pingcap:master Sep 28, 2020
@SwanSpouse SwanSpouse deleted the fix-error-hit branch September 28, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants