-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more test case for target's spec.TargetDir #820
Add more test case for target's spec.TargetDir #820
Conversation
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 51.26% 47.73% -3.53%
==========================================
Files 258 259 +1
Lines 18804 18833 +29
==========================================
- Hits 9639 8990 -649
- Misses 7649 8378 +729
+ Partials 1516 1465 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
570d2a0
to
3f8c03b
Compare
3f8c03b
to
03fb5f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@9547 merge failed. |
What problem does this PR solve?
Fix problems introduced by #755,
tiup update --self
results to~/.tiup/bin/tiup
deleted.and based on #816
What is changed and how it works?
in #755 L233-L237 were removed, revert thos lines back, and here we check the
targetDir
beforeInstallComponent
insideUpdateComponents
Check List
Tests
Code changes
Side effects
Related changes
Release notes: