Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: set timeout's type from int64 to uint64 #818

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

9547
Copy link
Contributor

@9547 9547 commented Sep 25, 2020

What problem does this PR solve?

fix #813

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #818 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
+ Coverage   52.56%   52.63%   +0.06%     
==========================================
  Files         262      262              
  Lines       18850    18850              
==========================================
+ Hits         9909     9921      +12     
+ Misses       7388     7381       -7     
+ Partials     1553     1548       -5     
Flag Coverage Δ
#cluster 44.73% <100.00%> (+0.09%) ⬆️
#dm 25.32% <100.00%> (-0.07%) ⬇️
#integrate 47.78% <100.00%> (+0.06%) ⬆️
#playground 22.22% <ø> (ø)
#tiup 10.93% <ø> (ø)
#unittest 18.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/ansible/import.go 61.98% <ø> (ø)
pkg/cluster/ansible/config.go 0.00% <ø> (ø)
pkg/cluster/ansible/inventory.go 54.16% <ø> (ø)
pkg/cluster/ansible/service.go 3.64% <ø> (ø)
pkg/cluster/manager.go 66.66% <ø> (ø)
pkg/cluster/operation/action.go 51.51% <ø> (ø)
pkg/cluster/operation/destroy.go 59.42% <ø> (ø)
pkg/cluster/operation/operation.go 78.26% <ø> (ø)
pkg/cluster/operation/scale_in.go 52.08% <ø> (ø)
pkg/cluster/spec/instance.go 65.87% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2232a...1b66bce. Read the comment docs.

@lonng lonng added this to the v1.2.0 milestone Sep 26, 2020
@lonng lonng added the type/enhancement Categorizes issue or PR as related to an enhancement. label Sep 26, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2020
@lonng lonng merged commit dfab8de into pingcap:master Sep 26, 2020
@9547 9547 deleted the fix/set-timeout-as-uint branch April 6, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Param value for --wait-timeout can not be negative number
4 participants