Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: redirect stdout to log files #815

Merged
merged 3 commits into from
Sep 27, 2020
Merged

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

save stdout as we did for stderr

What is changed and how it works?

redirect stdout to log files

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2020

CLA assistant check
All committers have signed the CLA.

@csuzhangxc
Copy link
Member Author

@july2993 PTAL

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #815 into master will increase coverage by 1.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   51.43%   52.78%   +1.34%     
==========================================
  Files         262      262              
  Lines       18971    18971              
==========================================
+ Hits         9758    10013     +255     
+ Misses       7657     7396     -261     
- Partials     1556     1562       +6     
Flag Coverage Δ
#cluster 44.75% <100.00%> (+2.32%) ⬆️
#dm 25.23% <100.00%> (+0.06%) ⬆️
#integrate 47.80% <100.00%> (+1.76%) ⬆️
#playground 22.17% <ø> (ø)
#tiup 10.83% <100.00%> (ø)
#unittest 18.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/embed/autogen_pkger.go 100.00% <100.00%> (ø)
pkg/cluster/spec/prometheus.go 73.11% <0.00%> (+1.07%) ⬆️
pkg/cluster/spec/grafana.go 65.11% <0.00%> (+1.16%) ⬆️
pkg/cluster/spec/spec.go 89.38% <0.00%> (+1.22%) ⬆️
pkg/cluster/api/dmapi.go 58.26% <0.00%> (+1.73%) ⬆️
pkg/cluster/spec/alertmanager.go 64.81% <0.00%> (+1.85%) ⬆️
pkg/cluster/api/binlog.go 43.82% <0.00%> (+2.24%) ⬆️
pkg/cluster/task/builder.go 97.10% <0.00%> (+2.47%) ⬆️
pkg/cluster/api/pdapi.go 53.54% <0.00%> (+3.22%) ⬆️
pkg/cluster/manager.go 66.32% <0.00%> (+4.35%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd751e4...6b25b19. Read the comment docs.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2020
@lonng lonng added this to the v1.2.0 milestone Sep 26, 2020
@lonng
Copy link
Contributor

lonng commented Sep 26, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 817
  • 816

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@csuzhangxc merge failed.

@july2993
Copy link
Contributor

@csuzhangxc pls resolve conflicts

@csuzhangxc
Copy link
Member Author

@july2993 PTAL again

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@july2993 july2993 merged commit d267189 into pingcap:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants