Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: support new cdc arguments gc-ttl and tz #770

Merged
merged 4 commits into from
Sep 13, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

TiCDC supports gc-ttl and tz arguments now. TiUP should also allow users to use these arguments.
ref: https://docs.pingcap.com/tidb/stable/manage-ticdc#use-binary

What is changed and how it works?

Add gc-ttl and tz arguments in CDCSpec and start_cdc_server script.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Release notes:

NONE

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2020

CLA assistant check
All committers have signed the CLA.

@lichunzhu lichunzhu changed the title template: support new cdc arguments template: support new cdc arguments gc-ttl and tz Sep 10, 2020
@lichunzhu lichunzhu requested review from AstroProfundis, lonng, july2993 and lucklove and removed request for AstroProfundis September 10, 2020 03:41
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2020
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@lonng
Copy link
Contributor

lonng commented Sep 13, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2020

Codecov Report

Merging #770 into master will decrease coverage by 3.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
- Coverage   54.71%   50.83%   -3.89%     
==========================================
  Files         260      260              
  Lines       21076    21080       +4     
==========================================
- Hits        11531    10715     -816     
- Misses       7991     8903     +912     
+ Partials     1554     1462      -92     
Flag Coverage Δ
#cluster 41.27% <100.00%> (-5.58%) ⬇️
#dm 26.92% <16.66%> (-0.01%) ⬇️
#integrate 46.07% <100.00%> (-3.92%) ⬇️
#playground 23.07% <ø> (ø)
#tiup 19.80% <ø> (ø)
#unittest 19.49% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/embed/autogen_pkger.go 100.00% <100.00%> (ø)
pkg/cluster/spec/cdc.go 81.53% <100.00%> (+0.58%) ⬆️
pkg/cluster/template/scripts/cdc.go 78.37% <100.00%> (+1.23%) ⬆️
components/cluster/command/check.go 6.86% <0.00%> (-72.88%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-70.00%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-68.43%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-54.53%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-53.85%) ⬇️
components/cluster/command/audit.go 38.46% <0.00%> (-46.16%) ⬇️
pkg/cluster/operation/operation.go 39.28% <0.00%> (-39.29%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380be8f...2121673. Read the comment docs.

@ti-srebot ti-srebot merged commit f824dc2 into pingcap:master Sep 13, 2020
@lichunzhu lichunzhu deleted the supportNewCDCArguments branch September 14, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants