-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import configuration when migrating a cluster from Ansible #766
Conversation
@yuzhibotao Please add some tests and format your code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may use go fmt
to format your code, and use make check && make test
for basic code formatting and unit test checks.
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 53.97% 49.46% -4.51%
==========================================
Files 257 258 +1
Lines 20965 21158 +193
==========================================
- Hits 11316 10466 -850
- Misses 8124 9226 +1102
+ Partials 1525 1466 -59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 53.26% 53.16% -0.10%
==========================================
Files 259 260 +1
Lines 18786 18909 +123
==========================================
+ Hits 10006 10053 +47
- Misses 7246 7318 +72
- Partials 1534 1538 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
What problem does this PR solve?
From ansible to tiup ,there is no configuration parameter for the import action.
What is changed and how it works?
After backing up the configuration files, parse the configuration files for each component, extract the same parameters into Server_Configs and put different parameters into the service's own Config.
Check List
Tests
old_meta.txt
new_meta.txt
Code changes
Side effects
Related changes
Release notes: