-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: restart prometheus after scaling the cluster #717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 57.93% 57.97% +0.03%
==========================================
Files 253 253
Lines 18522 18530 +8
==========================================
+ Hits 10731 10743 +12
+ Misses 6367 6365 -2
+ Partials 1424 1422 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/run-all-tests |
@AstroProfundis merge failed. |
What problem does this PR solve?
The prometheus config is not reloaded correctly after scaling in a cluster.
What is changed and how it works?
Restart the prometheus instance after updating configs, otherwise new configs are not applied.
Check List
Tests
Code changes
Side effects
Related changes
Release notes: