Support use local file or directory as config for monitor components

components/dm/spec/topology_dm.go

@@ -542,7 +542,11 @@ func (topo *Topology) Validate() error {
 		return err
 	}
 
-	return topo.dirConflictsDetect()
+	if err := topo.dirConflictsDetect(); err != nil {
+		return err
+	}
+
+	return spec.RelativePathDetect(topo)
 }
 
 // BaseTopo implements Topology interface.

pkg/cluster/spec/instance.go

@@ -191,8 +191,10 @@ func (i *BaseInstance) TransferLocalConfigDir(e executor.Executor, local, remote
 	}
 
 	for _, f := range files {
-		if err := i.TransferLocalConfigFile(e, path.Join(local, f.Name()), path.Join(remote, f.Name())); err != nil {
-			return errors.Annotatef(err, "transfer local config %s failed", path.Join(local, f.Name()))
+		localPath := path.Join(local, f.Name())
+		remotePath := path.Join(remote, f.Name())
+		if err := i.TransferLocalConfigFile(e, localPath, remotePath); err != nil {
+			return errors.Annotatef(err, "transfer local config (%s -> %s) failed", localPath, remotePath)
 		}
 	}
 

pkg/cluster/spec/prometheus.go

@@ -204,11 +204,13 @@ func (i *MonitorInstance) initRules(e executor.Executor, spec PrometheusSpec, pa
 		if err := i.TransferLocalConfigDir(e, spec.RuleDir, path.Join(paths.Deploy, "conf")); err != nil {
 			return errors.Annotate(err, "transfer prometheus rules failed")
 		}
-	} else { // Use the default ones
-		cmd := fmt.Sprintf("cp %[1]s/bin/prometheus/*.rules.yml %[1]s/conf/", paths.Deploy)
-		if _, _, err := e.Execute(cmd, false); err != nil {
-			return errors.Annotatef(err, "execute command failed: %s", err)
-		}
+		return nil
+	}
+
+	// Use the default ones
+	cmd := fmt.Sprintf("cp %[1]s/bin/prometheus/*.rules.yml %[1]s/conf/", paths.Deploy)
+	if _, _, err := e.Execute(cmd, false); err != nil {
+		return errors.Annotatef(err, "execute command failed: %s", err)
 	}
 
 	return nil

pkg/cluster/spec/validate.go

@@ -674,5 +674,45 @@ func (s *Specification) Validate() error {
 		return err
 	}
 
-	return s.validateTiSparkSpec()
+	if err := s.validateTiSparkSpec(); err != nil {
+		return err
+	}
+
+	return RelativePathDetect(s)
+}
+
+// RelativePathDetect detect if some specific path is relative path and report error
+func RelativePathDetect(topo interface{}) error {
+	pathTypes := []string{
+		"ConfigFilePath",
+		"RuleDir",
+		"DashboardDir",
+	}
+
+	topoSpec := reflect.ValueOf(topo).Elem()
+
+	for i := 0; i < topoSpec.NumField(); i++ {
+		if isSkipField(topoSpec.Field(i)) {
+			continue
+		}
+
+		compSpecs := topoSpec.Field(i)
+		for index := 0; index < compSpecs.Len(); index++ {
+			compSpec := compSpecs.Index(index)
+
+			// Relateve path detect
+			for _, field := range pathTypes {
+				if j, found := findField(compSpec, field); found {
+					// `yaml:"xxxx,omitempty"`
+					fieldName := strings.Split(compSpec.Type().Field(j).Tag.Get("yaml"), ",")[0]
+					localPath := compSpec.Field(j).String()
+					if localPath != "" && !strings.HasPrefix(localPath, "/") {
+						return fmt.Errorf("relative path is not allowed for field %s: %s", fieldName, localPath)
+					}
+				}
+			}
+		}
+	}
+
+	return nil
 }