-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve env init on deploying and scale-out cluster #678
Conversation
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some tests.
Signed-off-by: lucklove <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
+ Coverage 57.55% 57.61% +0.05%
==========================================
Files 250 250
Lines 17932 17941 +9
==========================================
+ Hits 10321 10336 +15
+ Misses 6256 6250 -6
Partials 1355 1355
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: lucklove <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: lucklove <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@lucklove merge failed. |
What problem does this PR solve?
At this time, we will create the user which is specified in topology.yml on
deploy
andscale-out
stage.However, the topology.yml only allows specifying the user name excepting the user group name. Sometimes the user may want to create the user, but using an existed group name.
BTW: fix #677
What is changed and how it works?
Add a
group
field in the topology fileCheck List
Tests
Release notes: