-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rename cluster #671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command will refresh config and restart grafana and prometheus Signed-off-by: lucklove <[email protected]>
Signed-off-by: lucklove <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
+ Coverage 57.53% 57.59% +0.06%
==========================================
Files 249 250 +1
Lines 17891 17920 +29
==========================================
+ Hits 10293 10321 +28
- Misses 6248 6249 +1
Partials 1350 1350
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lonng
reviewed
Aug 12, 2020
lonng
reviewed
Aug 12, 2020
Signed-off-by: lucklove <[email protected]>
lonng
approved these changes
Aug 14, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Aug 14, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
type/new-feature
Categorizes pr as related to a new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Make it possible to rename cluster.
What is changed and how it works?
Rename the cluster storage folder and reload prometheus and grafana.
eg:
tiup cluster rename old new
equals to:Check List
Tests
Side effects
Grafana stores some data related to cluster name to its grafana.db. The rename action will NOT delete them. So there may be some useless panel need to be deleted manually.
Release notes: