Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PD config incompatible when retrieving dashboard address #638

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Jul 29, 2020

Signed-off-by: Lonng [email protected]

What problem does this PR solve?

Fix #637

Fix PD config incompatible when retrieving dashboard address

Manual test:

➜  tiup git:(pr/638) bin/tiup-cluster display simple
TiDB Cluster: simple
TiDB Version: v4.0.3
ID                     Role  Host             Ports        OS/Arch       Status  Data Dir  Deploy Dir
--                     ----  ----             -----        -------       ------  --------  ----------
192.168.137.101:2379   pd    192.168.137.101  2379/2380    linux/x86_64  Up      data      deploy/pd-2379
192.168.137.102:2379   pd    192.168.137.102  2379/2380    linux/x86_64  Up|L    data      deploy/pd-2379
192.168.137.103:2379   pd    192.168.137.103  2379/2380    linux/x86_64  Up|UI   data      deploy/pd-2379
192.168.137.101:4000   tidb  192.168.137.101  4000/10080   linux/x86_64  Up      -         deploy/tidb-4000
192.168.137.101:20160  tikv  192.168.137.101  20160/20180  linux/x86_64  Up      data      deploy/tikv-20160
192.168.137.102:20160  tikv  192.168.137.102  20160/20180  linux/x86_64  Up      data      deploy/tikv-20160
192.168.137.103:20160  tikv  192.168.137.103  20160/20180  linux/x86_64  Up      data      deploy/tikv-20160
➜  tiup git:(pr/638) bin/tiup-cluster display simple --dashboard
http://192.168.137.103:2379/dashboard/

@lonng lonng added the type/bug-fix Categorizes PR as a bug-fix label Jul 29, 2020
Copy link
Contributor

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@baurine,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: tiup(slack).

@ti-srebot
Copy link
Contributor

@baurine,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: tiup(slack).

@lonng lonng added this to the v1.1.0 milestone Jul 29, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 29, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #638 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
+ Coverage   47.79%   47.97%   +0.17%     
==========================================
  Files         224      224              
  Lines       16818    16824       +6     
==========================================
+ Hits         8038     8071      +33     
+ Misses       7653     7628      -25     
+ Partials     1127     1125       -2     
Flag Coverage Δ
#coverage 47.97% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hub.com/pingcap/tiup/components/playground/main.go 80.83% <0.00%> (+0.59%) ⬆️
...m/pingcap/tiup/components/playground/playground.go 30.33% <0.00%> (+1.12%) ⬆️
...c/github.com/pingcap/tiup/pkg/cluster/api/pdapi.go 54.87% <0.00%> (+2.70%) ⬆️
go/src/github.com/pingcap/tiup/pkg/utils/ioutil.go 47.54% <0.00%> (+10.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1142b1...e2afb30. Read the comment docs.

@july2993 july2993 merged commit 651808e into master Jul 29, 2020
@july2993 july2993 deleted the fix-dashboard branch July 29, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't find where dashboard is though tiup cluster display command
5 participants